Re: Top kernel oopses/warnings for the week of May 16th 2008

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Robert Hancock
Date: Saturday, May 17, 2008 - 10:38 am

Andrea Arcangeli wrote:

What was the original patch that you were trying to fix? If it's this 
one, it does seem to be wrong:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=419c434c35...

author	Yang Shi <yang.shi@windriver.com>
	Tue, 4 Mar 2008 10:20:51 +0000 (11:20 +0100)
committer	Jens Axboe <jens.axboe@oracle.com>
	Tue, 4 Mar 2008 10:20:51 +0000 (11:20 +0100)

Fix DMA access of block device in 64-bit kernel on some non-x86 systems 
with 4GB or upper 4GB memory

Originally it was using the DMA path only for DMA masks of less than 
32-bit. This change made it use that path for 32-bit or less. Looking 
more closely it doesn't seem like your patch is really harmful, it just 
doesn't completely repair the damage from the first one.

IMO both of these patches should just be reverted. The commit 
description doesn't specify what arch the first one was trying to fix 
but it seems to break x86_64 anyway..
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: Top kernel oopses/warnings for the week of May 16th 2008, Andrea Arcangeli, (Sat May 17, 7:12 am)
Re: Top kernel oopses/warnings for the week of May 16th 2008, Arjan van de Ven, (Sat May 17, 7:57 am)
Re: Top kernel oopses/warnings for the week of May 16th 2008, Robert Hancock, (Sat May 17, 10:38 am)
Re: Top kernel oopses/warnings for the week of May 16th 2008, Andrea Arcangeli, (Sat May 17, 1:34 pm)