2.6.26-rc2-mm1 and Linus -git: LEDS_TRIGGER_DEFAULT_ON odd default

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Andrew Morton <akpm@...>, <rpurdie@...>
Cc: <linux-kernel@...>
Date: Saturday, May 17, 2008 - 6:28 am

On Wed, 14 May 2008 01:01:29 PDT, Andrew Morton said:

Seen in a 'make silentoldconfig':

---
    LED Default ON Trigger (LEDS_TRIGGER_DEFAULT_ON) [N/m/y/?] (NEW) ?

This allows LEDs to be initialised in the ON state.
If unsure, say Y.
---

The default is N, but if unsure, say Y.  Some digging shows that it's because
there's a "depends on LEDS_TRIGGERS" that I had set to N.  I wonder if the
various 'config LEDS_TRIGGER_FOO' in drivers/leds/Kconfig should all be
wrapped in one 'if LEDS_TRIGGERS'?  Kind of like this totally untested patch:

If I'm actually right here, here's a:

Signed-Off-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>

--- linux-2.6.26-rc2-mm1/drivers/leds/Kconfig.before	2008-05-17 06:22:03.000000000 -0400
+++ linux-2.6.26-rc2-mm1/drivers/leds/Kconfig	2008-05-17 06:22:55.000000000 -0400
@@ -164,9 +164,9 @@ config LEDS_TRIGGERS
 	  These triggers allow kernel events to drive the LEDs and can
 	  be configured via sysfs. If unsure, say Y.
 
+if LEDS_TRIGGERS
 config LEDS_TRIGGER_TIMER
 	tristate "LED Timer Trigger"
-	depends on LEDS_TRIGGERS
 	help
 	  This allows LEDs to be controlled by a programmable timer
 	  via sysfs. Some LED hardware can be programmed to start
@@ -177,14 +177,13 @@ config LEDS_TRIGGER_TIMER
 
 config LEDS_TRIGGER_IDE_DISK
 	bool "LED IDE Disk Trigger"
-	depends on LEDS_TRIGGERS && BLK_DEV_IDEDISK
+	depends on BLK_DEV_IDEDISK
 	help
 	  This allows LEDs to be controlled by IDE disk activity.
 	  If unsure, say Y.
 
 config LEDS_TRIGGER_HEARTBEAT
 	tristate "LED Heartbeat Trigger"
-	depends on LEDS_TRIGGERS
 	help
 	  This allows LEDs to be controlled by a CPU load average.
 	  The flash frequency is a hyperbolic function of the 1-minute
@@ -193,9 +192,9 @@ config LEDS_TRIGGER_HEARTBEAT
 
 config LEDS_TRIGGER_DEFAULT_ON
 	tristate "LED Default ON Trigger"
-	depends on LEDS_TRIGGERS
 	help
 	  This allows LEDs to be initialised in the ON state.
 	  If unsure, say Y.
 
+endif # LEDS_TRIGGERS
 endif # NEW_LEDS
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
2.6.26-rc2-mm1, Andrew Morton, (Wed May 14, 4:01 am)
Re: 2.6.26-rc2-mm1: possible circular locking dependency det..., Mariusz Kozlowski, (Tue May 20, 6:01 am)
Re: 2.6.26-rc2-mm1 - machine stuck while booting up with CON..., Kamalesh Babulal, (Mon May 19, 10:08 am)
2.6.26-rc2-mm1 and Linus -git: LEDS_TRIGGER_DEFAULT_ON odd d..., , (Sat May 17, 6:28 am)
2.6.26-rc2-mm1: high speed something, Alexey Dobriyan, (Fri May 16, 6:17 pm)
Re: 2.6.26-rc2-mm1: high speed something, Andrew Morton, (Fri May 16, 5:31 pm)
Re: 2.6.26-rc2-mm1: high speed something, Greg KH, (Fri May 16, 6:00 pm)
[BUG] Re: 2.6.26-rc2-mm1 - x86_32 oops on modprobe wusbcore, Mariusz Kozlowski, (Thu May 15, 2:21 pm)
Re: [BUG] Re: 2.6.26-rc2-mm1 - x86_32 oops on modprobe wusbc..., Inaky Perez-Gonzalez, (Thu May 15, 4:05 pm)
[PATCH] Re: 2.6.26-rc2-mm1 - fix parenthesis in include/asm-..., Mariusz Kozlowski, (Thu May 15, 2:01 pm)
[PATCH] Re: 2.6.26-rc2-mm1 - fix parenthesis in include/asm-..., Mariusz Kozlowski, (Thu May 15, 1:59 pm)
[PATCH] Re: 2.6.26-rc2-mm1 - fix parenthesis in include/asm-..., Mariusz Kozlowski, (Thu May 15, 1:58 pm)
Re: 2.6.26-rc2-mm1, Rafael J. Wysocki, (Wed May 14, 5:54 pm)
Re: 2.6.26-rc2-mm1 (p9 build error when 9P_FS=n), Randy Dunlap, (Wed May 14, 5:16 pm)
Re: 2.6.26-rc2-mm1 (p9 build error when 9P_FS=n), Eric Van Hensbergen, (Wed May 14, 8:00 pm)
Re: 2.6.26-rc2-mm1 (p9 build error when 9P_FS=n), Andrew Morton, (Wed May 14, 8:05 pm)
Re: 2.6.26-rc2-mm1 (p9 build error when 9P_FS=n), Eric Van Hensbergen, (Wed May 14, 10:29 pm)
Re: 2.6.26-rc2-mm1 (p9 build error when 9P_FS=n), Andrew Morton, (Wed May 14, 11:04 pm)
Re: 2.6.26-rc2-mm1 (p9 build error when 9P_FS=n), Eric Van Hensbergen, (Wed May 14, 11:53 pm)
Re: 2.6.26-rc2-mm1 (SCSI_DH build errors), Randy Dunlap, (Wed May 14, 5:13 pm)
Re: 2.6.26-rc2-mm1 (SCSI_DH build errors), James Bottomley, (Thu May 15, 10:46 am)
Re: 2.6.26-rc2-mm1 (SCSI_DH build errors), Chandra Seetharaman, (Thu May 15, 3:56 pm)
Re: 2.6.26-rc2-mm1 (SCSI_DH build errors), Andrew Morton, (Thu May 22, 11:25 pm)
Re: 2.6.26-rc2-mm1 (SCSI_DH build errors), Chandra Seetharaman, (Fri May 23, 3:39 pm)
Re: 2.6.26-rc2-mm1 (SCSI_DH build errors), Randy Dunlap, (Fri May 23, 4:28 pm)
Re: 2.6.26-rc2-mm1 (SCSI_DH build errors), Chandra Seetharaman, (Fri May 23, 9:16 pm)
Re: 2.6.26-rc2-mm1, Zan Lynx, (Wed May 14, 4:49 pm)
Re: 2.6.26-rc2-mm1, Andrew Morton, (Wed May 14, 5:00 pm)
Re: 2.6.26-rc2-mm1, me, (Wed May 14, 5:14 pm)
Re: 2.6.26-rc2-mm1, Zan Lynx, (Wed May 14, 6:06 pm)
Re: 2.6.26-rc2-mm1 (CONFIG_*FD build errors), Randy Dunlap, (Wed May 14, 4:43 pm)
Re: 2.6.26-rc2-mm1 (WARN() build error), Randy Dunlap, (Wed May 14, 4:39 pm)
2.6.26-rc2-mm1: sloooow mkfs.ext2, Alexey Dobriyan, (Wed May 14, 5:16 pm)
Re: 2.6.26-rc2-mm1: sloooow mkfs.ext2, Alexey Dobriyan, (Wed May 14, 5:33 pm)
Re: 2.6.26-rc2-mm1: sloooow mkfs.ext2, Jiri Slaby, (Thu May 15, 5:41 pm)
Re: 2.6.26-rc2-mm1, Torsten Kaiser, (Wed May 14, 3:12 pm)
Re: 2.6.26-rc2-mm1, Andrew Morton, (Wed May 14, 3:35 pm)
Re: 2.6.26-rc2-mm1, Torsten Kaiser, (Thu May 15, 1:44 pm)
Re: 2.6.26-rc2-mm1, Andrew Morton, (Thu May 15, 2:49 pm)
Re: 2.6.26-rc2-mm1: sparc64 - possible recursive locking det..., Mariusz Kozlowski, (Wed May 14, 2:29 pm)
Re: 2.6.26-rc2-mm1: sparc64 - possible recursive locking det..., Mariusz Kozlowski, (Wed May 14, 2:50 pm)
[BUG] 2.6.26-rc2-mm1 - kernel panic at inet_create() on powe..., Kamalesh Babulal, (Wed May 14, 11:34 am)
Re: [BUG] 2.6.26-rc2-mm1 - kernel panic at inet_create() on ..., Paul E. McKenney, (Wed May 14, 12:07 pm)
[BUG] 2.6.26-rc2-mm1 - kernel BUG at fs/reiserfs/journal.c:1..., Kamalesh Babulal, (Wed May 14, 10:03 am)
Re: [BUG] 2.6.26-rc2-mm1 - kernel bug while bootup at __allo..., Lee Schermerhorn, (Mon May 19, 10:49 am)
Re: [BUG] 2.6.26-rc2-mm1 - kernel bug while bootup at __allo..., KAMEZAWA Hiroyuki, (Wed May 14, 9:54 pm)