Re: [GIT pull] x86 fixes for 2.6.26

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Friday, May 16, 2008 - 5:03 pm

On Sat, 17 May 2008, Thomas Gleixner wrote:

Listen to yourself. They are "topic" branches. They are supposed to do one 
thing. You keep them "uptodate" by doing your work on them, _not_ by 
merging everybody elses work into them.


You _used_ to rebase. That hides bad workflows, because it hides the fact 
that your "topic branch" is not a topic branch at all, but something that 
tries to do much more than it's stated purpose.

So now, when you stopped rebasing, the fact that you keep updating your 
topic branches with code that has nothing to do with your topic (ie code 
that I randomly merged from me) is visible as the unnecessary merges.

Yes, doing a merge occasionally just to not fell *too* far behind is sane. 
But when you have twice as many merges as you have real commits, you're 
doing something wrong. At that point, you're no longer a topic branch, 
you're just a mess of other peoples development merged on top of random 
commits you do.

See the difference? You literally merged four times in two days. That's 
not "keeping reasonably up-to-date", that's just messy and OCD.

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT pull] x86 fixes for 2.6.26, Thomas Gleixner, (Fri May 16, 3:38 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Linus Torvalds, (Fri May 16, 3:47 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Linus Torvalds, (Fri May 16, 3:51 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Thomas Gleixner, (Fri May 16, 4:44 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Linus Torvalds, (Fri May 16, 5:03 pm)
Re: [GIT pull] x86 fixes for 2.6.26, David Miller, (Fri May 16, 5:28 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Linus Torvalds, (Fri May 16, 6:38 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Theodore Tso, (Fri May 16, 6:57 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Linus Torvalds, (Fri May 16, 8:19 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Theodore Tso, (Sat May 17, 7:58 am)
Re: [GIT pull] x86 fixes for 2.6.26, Linus Torvalds, (Sat May 17, 10:05 am)
Re: [GIT pull] x86 fixes for 2.6.26, Ingo Molnar, (Sat May 17, 12:39 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Linus Torvalds, (Sat May 17, 1:00 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Junio C Hamano, (Sat May 17, 1:26 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Thomas Gleixner, (Sat May 17, 1:37 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Thomas Gleixner, (Sat May 17, 2:02 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Linus Torvalds, (Sat May 17, 2:36 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Jesper Juhl, (Sat May 17, 3:45 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Linus Torvalds, (Sat May 17, 5:35 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Stephen Rothwell, (Sat May 17, 7:22 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Jesper Juhl, (Sun May 18, 3:09 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Linus Torvalds, (Sun May 18, 3:26 pm)
Re: [GIT pull] x86 fixes for 2.6.26, Jesper Juhl, (Mon May 19, 5:01 pm)