linux-kernel mailing list

FromSubjectsort iconDate
David Miller
[PATCH 2/2]: sparc64: Add Niagara2 RNG driver.
Signed-off-by: David S. Miller <davem@davemloft.net> --- drivers/char/hw_random/Kconfig | 13 + drivers/char/hw_random/Makefile | 2 + drivers/char/hw_random/n2-asm.S | 93 +++++ drivers/char/hw_random/n2-drv.c | 771 +++++++++++++++++++++++++++++++++++++++ drivers/char/hw_random/n2rng.h | 118 ++++++ 5 files changed, 997 insertions(+), 0 deletions(-) create mode 100644 drivers/char/hw_random/n2-asm.S create mode 100644 drivers/char/hw_random/n2-drv.c create mode 100644 driv...
May 16, 7:53 pm 2008
David Miller
[PATCH 1/2]: sparc64: Add missing hypervisor service group n...
Signed-off-by: David S. Miller <davem@davemloft.net> --- arch/sparc64/kernel/hvapi.c | 4 ++++ include/asm-sparc64/hypervisor.h | 4 ++++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/sparc64/kernel/hvapi.c b/arch/sparc64/kernel/hvapi.c index f34f5d6..691760b 100644 --- a/arch/sparc64/kernel/hvapi.c +++ b/arch/sparc64/kernel/hvapi.c @@ -34,8 +34,12 @@ static struct api_info api_table[] = { { .group = HV_GRP_LDOM, }, { .group = HV_GRP_SVC_CHAN, .f...
May 16, 7:53 pm 2008
David Miller
[PATCH 0/2]: Niagara2 RNG driver.
These next two patches implement the RNG driver for Niagara2. They are also available on the master branch at: git://git.kernel.org/pub/scm/linux/kernel/git/davem/n2rng-2.6.git The driver transparently works on both control and guest nodes in virtualized environments. I've testedit on both single and dual socket Niagara2 systems, and rngd seems to be happy with the output. Below is a typical driver load and rng stats message log. Signed-off-by: David S. Miller <davem@davemloft.net> ...
May 16, 7:53 pm 2008
Dave Jones
gianfar build failure.
Hi Paul, Since your commit d0313587547092af7f5ee8a576793e1e5d61be89 I see this build failure: "get_phy_id" [drivers/net/gianfar_driver.ko] undefined! both CONFIG_PHYLIB and CONFIG_GIANFAR are =m Missing exports ? Dave -- http://www.codemonkey.org.uk --
May 16, 7:29 pm 2008
Paul Gortmaker
Re: gianfar build failure.
Thanks Dave -- I'll look into it and get a fix out. Paul. --
May 16, 7:39 pm 2008
Randy Dunlap
[PATCH] kernel-doc: allow unnamed bit-fields
From: Randy Dunlap <randy.dunlap@oracle.com> Allow for unnamed bit-fields and skip them instead of printing an erroneous warning message for them, such as: Warning(include/asm-s390/cio.h:103): No description found for parameter 'u32' which contains: struct tm_scsw { u32 :1; Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> --- scripts/kernel-doc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- next-20080516.orig/scripts/kernel-doc +++ next-20080516/sc...
May 16, 6:45 pm 2008
Thomas Gleixner
[GIT pull] x86 fixes for 2.6.26
Linus, please pull the latest x86 fixes from: ssh://master.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git x86-fixes-for-linus Thanks, tglx ------------------> Avi Kivity (1): x86: fix crash on cpu hotplug on pat-incapable machines Ingo Molnar (1): x86: remove mwait capability C-state check Thomas Gleixner (1): x86: disable mwait for AMD family 10H/11H CPUs arch/x86/kernel/process.c | 36 +++++++++++++++++++++++++++--------- arch/x86/mm/pat...
May 16, 6:38 pm 2008
Linus Torvalds
Re: [GIT pull] x86 fixes for 2.6.26
No. You have three real commits there. And *six* unnecessary merges. Why do you merge my tree? Is it the x86 tree, or is it the "general development tree"? If it's the x86 tree, it shouldn't need to merge everythign else all the time. Certainly not if it means that moer than half the commits are just merges. Do nice topic branches, where each branch has a reason for existing. The "x86-fixes-for-linus" branch has x86 fixes. This happens almost every time somebody starts using...
May 16, 6:47 pm 2008
Thomas Gleixner
Re: [GIT pull] x86 fixes for 2.6.26
We have topic branches. How should we keep those topic branches up We did not rebase at all. All we did is keeping the branches up to date vs. your tree, which introduces merges whether we want or not. I'm well aware of the merge commit issue, but I have no real good idea how to avoid rebasing in order to keep the history intact and avoid the merge commits at the same time. Thanks, tglx --
May 16, 7:44 pm 2008
Linus Torvalds
Re: [GIT pull] x86 fixes for 2.6.26
Side note: to see this in action, just do gitk linus.. on that branch tip. Or look at the shortlog output without --no-merges: Avi Kivity (1): x86: fix crash on cpu hotplug on pat-incapable machines Ingo Molnar (6): Merge branch 'linus' into x86/urgent Merge branch 'linus' into x86/urgent Merge branch 'linus' into x86/urgent Merge branch 'x86/urgent' of e2:tip into x86/urgent x86: remove mwait capability C-state check Merge branch ...
May 16, 6:51 pm 2008
Alexey Dobriyan
[PATCH] arm: switch /proc/cpu/alignment to seq_files
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> --- arch/arm/mm/alignment.c | 55 +++++++++++++++++++++++------------------------- 1 file changed, 27 insertions(+), 28 deletions(-) --- a/arch/arm/mm/alignment.c +++ b/arch/arm/mm/alignment.c @@ -16,6 +16,7 @@ #include <linux/errno.h> #include <linux/string.h> #include <linux/proc_fs.h> +#include <linux/seq_file.h> #include <linux/init.h> #include <asm/uaccess.h> @@ -80,36 +81,28 @@ st...
May 16, 7:34 pm 2008
Linus Torvalds
Remove BKL from FAT/VFAT/MSDOS (v1) (was Re: Fw: Regression ...
Ok, this was also the only one that was called under the superblock lock (sys_umount->deactivate_super->invalidate_inodes->clear_inode), and everything else could be directly converted to use the superblock lock, so here's a trial balloon patch that does exactly that: just blindly convert all the "lock_kernel()" calls to "lock_super(sb)", except for the one in fat_clear_inode(), which is dropped entirely. NOTE! There's no way in hell I'll actually commit this, but I did test it ...
May 16, 6:36 pm 2008
Linus Torvalds
Re: Remove BKL from FAT/VFAT/MSDOS (v1) (was Re: Fw: Regress...
To clarify: lock_super() is actually a much *stronger* lock than lock_kernel(), which is why testing is actually interesting: the locking hasn't been weakened, it's actually become much stricter (because unlike the kernel lock, the superblock lock is kept over scheduling events, and doesn't silently nest). So the most likely failure case is not that some locking went away and you'd race on the data structures, it's that something deadlocks on itself if the locking isn't right. There ...
May 16, 6:58 pm 2008
Johannes Weiner
bootmem: Double freeing a PFN on nodes spanning other nodes
Hi, When memory nodes overlap each other, the bootmem allocator is not aware of this and might pass the same page twice to __free_pages_bootmem(). As I traced the code, this should result in bad_page() calls on every boot but noone has yet reported something like this and I am wondering why. __free_pages_bootmem() boils down to either free_hot_cold_page() or __free_one_page(). Either path should lead to setting the page private or buddy: free_hot_cold_page() sets ->private to the page b...
May 16, 6:30 pm 2008
David Miller
[GIT]: Sparc
This fixes the regression reported by Mikael Pettersson, which is in the 2.6.26-rcX regression list. Please pull, thanks a lot! The following changes since commit f26a3988917913b3d11b2bd741601a2c64ab9204: Linus Torvalds (1): Merge branch 'merge' of git://git.kernel.org/.../paulus/powerpc are available in the git repository at: master.kernel.org:/pub/scm/linux/kernel/git/davem/sparc-2.6.git master David S. Miller (2): sparc64: Fix lmb_reserve() args in find_ramdisk(). ...
May 16, 6:27 pm 2008
Scott D. Davilla
Re: [PATCH] Input: add appleir USB driver
That would be me sending to Greg. my bad. I should be posting here and I've disciplined myself accordingly (a smack upside the head). The history of the appleir patch is that James McKenzie created it as a method to get IR controller support working for the MacMini. This was way back in time before Apple EFI even had a PC BIOS compatibility layer. The patch was migrated to the MacTel mactel-linux svn by huceke and stayed for 2.6.17, 2.6.18, 2.6.20 and 2.6.21 kernel usage. There were numero...
May 16, 5:46 pm 2008
Jo Shields
GPL Violation: Compro Technology Inc, 2.6.17 modified binary...
Hi, I've discovered a GPL violation by Taiwanese TV card manufacturer Compro Technology. On their site, they are offering a "driver" for Mandriva Linux 2007.1, in the form of an 18 meg "linux.rpm"[1,2,3,4]. This "driver" is, in fact, an entire kernel image (from snd-emu10k1.ko to libata.ko, with everything in between), generated from Mandriva's kernel source package, with local modifications to at least two files (major file size gap between Compro and Mandriva kernels in tuner.ko and cx88xx.ko...
May 16, 6:00 pm 2008
FD Cami
Re: GPL Violation: Compro Technology Inc, 2.6.17 modified bi...
(adding gpl-violations.org in CC) -- fdc On Fri, 16 May 2008 23:00:12 +0100 --
May 16, 6:32 pm 2008
Marc Rantanen
Oops: 0000 [#1] SMP //// HPT raid card 1740
Can't get the new driver for HPT 1740 working in kernel gentoo-2.6.24-r8 module: rr174x (v.2.1) /marc ------------------------ rr174x: module license 'Proprietary' taints kernel. rr174x:RocketRAID 174x controller driver v2.1.08.0303 (May 16 2008 15:58:03) BUG: unable to handle kernel paging request at virtual address 64091fd0 printing eip: f8905688 *pde = 00000000 Oops: 0000 [#1] SMP Modules linked in: rr174x(P) scsi_wait_scan Pid: 3411, comm: modprobe Tainted: P (2.6.24-gentoo-r8 ...
May 16, 5:14 pm 2008
Justin Mattock
ACPI: EC: GPE
Hello; I dont have a problem with that(bug report), I'm just concerned with the system right now, I'm hearing the fans rev up a little more than usually Feels like there's more stress on the system than there normally is. Should I just go ahead and revert back to 2.6.26-rc1 to be safe, or just stay with the latest git irregardless of the slight overhead. regards; -- Justin P. Mattock --
May 16, 5:25 pm 2008
Nate Case
[PATCH v3] leds: Add support for Philips PCA955x I2C LED dri...
This driver supports the PCA9550, PCA9551, PCA9552, and PCA9553 LED driver chips. Signed-off-by: Nate Case <ncase@xes-inc.com> --- Note: This version incorporates the changes suggested by Andrew Morton. Corrected messed up e-mail body from v2 to fix the log message. Sorry for the patch spam :) drivers/leds/Kconfig | 8 + drivers/leds/Makefile | 1 + drivers/leds/leds-pca955x.c | 401 +++++++++++++++++++++++++++++++++++++++++++ include/linux/leds.h | 14 ++ ...
May 16, 5:09 pm 2008
Nate Case
[PATCH v2] leds: Add support for Philips PCA955x I2C LED dri...
>From 64305461c086777470ae624c1bf3b8dc69e203a5 Mon Sep 17 00:00:00 2001 From: Nate Case <ncase@xes-inc.com> Date: Wed, 26 Mar 2008 16:36:33 -0500 Subject: [PATCH] leds: Add support for Philips PCA955x I2C LED drivers This driver supports the PCA9550, PCA9551, PCA9552, and PCA9553 LED driver chips. Signed-off-by: Nate Case <ncase@xes-inc.com> --- Note: This version incorporates the changes suggested by Andrew Morton drivers/leds/Kconfig | 8 + drivers/leds/Makefile ...
May 16, 5:04 pm 2008
Al Viro
[PATCH] fix hppfs Makefile breakage
Fallout from commit 46d7b522ebf486edbd096965d534cc6465e9e309 Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Acked-by: Jeff Dike <jdike@addtoit.com> --- diff --git a/fs/hppfs/Makefile b/fs/hppfs/Makefile index 8a1f503..3a982bd 100644 --- a/fs/hppfs/Makefile +++ b/fs/hppfs/Makefile @@ -3,7 +3,4 @@ # Licensed under the GPL # -hppfs-objs := hppfs.o - -obj-y = -obj-$(CONFIG_HPPFS) += $(hppfs-objs) +obj-$(CONFIG_HPPFS) += hppfs.o --
May 16, 5:01 pm 2008
Al Viro
[PATCH] fix include order in sys-i386/registers.c
We want sys/ptrace.h before any includes of linux/ptrace.h and asm/user.h pulls the latter. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Acked-by: Jeff Dike <jdike@addtoit.com> --- diff --git a/arch/um/os-Linux/sys-i386/registers.c b/arch/um/os-Linux/sys-i386/registers.c index c6183e7..b487cbe 100644 --- a/arch/um/os-Linux/sys-i386/registers.c +++ b/arch/um/os-Linux/sys-i386/registers.c @@ -5,6 +5,7 @@ */ #include <errno.h> +#include <sys/ptrace.h> #include...
May 16, 5:00 pm 2008
Al Viro
[PATCH] missed kmalloc() in pcap_user.c
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Acked-by: Jeff Dike <jdike@addtoit.com> --- diff --git a/arch/um/drivers/pcap_user.c b/arch/um/drivers/pcap_user.c index e980935..5f90358 100644 --- a/arch/um/drivers/pcap_user.c +++ b/arch/um/drivers/pcap_user.c @@ -50,7 +50,7 @@ static int pcap_open(void *data) return -EIO; } - pri->compiled = kmalloc(sizeof(struct bpf_program), + pri->compiled = uml_kmalloc(sizeof(struct bpf_program), UM_GFP_KERNEL); if...
May 16, 4:58 pm 2008
Andrea Righi
[PATCH] distinct tgid/tid I/O statistics (was: taskstats and...
Balbir, Mark, what do you think about the following approach? Patch against 2.6.25.4, tested in KVM. -Andrea -- Report per-thread I/O statistics in /proc/pid/task/tid/io and aggregate parent I/O statistics in /proc/pid/io. This approach follows the same model used to account per-process and per-thread CPU times. As a practial application, this allows for example to quickly find the top I/O consumer when a process spawns many child threads that perform the actual I/O work, because the agg...
May 16, 4:38 pm 2008
Benny Amorsen
Re: [PATCH] drivers/net: remove network drivers' last few us...
Perhaps it would be possible to make most types of interrupts add entropy, but not credit any entropy? /Benny --
May 16, 4:34 pm 2008
Bruno
Input+S3: extra keycodes forgotten after suspend
On my Acer TravelMate 660 I lose keycodes for the extra keys (dritek extensions) after resume. The system runs setkeycodes during boot sequence to initialize key codes for the extra keys as below: /usr/bin/setkeycodes KEYCODES="e025 138 e026 141 e027 171 e074 148 e073 149 e055 229 e056 230 e057 227 e058 228" # Fn + F1 ~ e025 => 138 [KEY_HELP] (Help) # Fn + F2 ~ e026 => 141 [KEY_SETUP] (Notebook Manager) # Fn + F3 ~ e027 => 171 [KEY_CONFIG] (Power Options) # Mail ~ e06c =&...
May 16, 4:25 pm 2008
Dmitry Torokhov
Re: Input+S3: extra keycodes forgotten after suspend
Hi Bruno, Do you unload atkbd or perhaps i8042 for s2ram? Or do you see that keyboard is detected again (in dmesg) after resume? -- Dmitry --
May 16, 4:38 pm 2008
Bruno
Re: Input+S3: extra keycodes forgotten after suspend
Hi Dmitry, I don't see anything in the logs that would allow to assume this. Most is built right into the kernel. Modules that were loaded for suspend/resume process (USB unloaded before trying to suspend, alsa also stopped): Module Size Used by pcspkr 2176 0 sunrpc 159996 17 nfs,lockd,nfs_acl 8021q 17096 0 xfs 498804 4 nsc_ircc 14480 0 irda 102584 1 nsc_ircc crc_cc...
May 16, 5:00 pm 2008
Bruno
[PATCH] Input: i8042 - add Dritek quirk for Acer TravelMate ...
The Acer TravelMate 660 series also requires the Dritek quirk to enable the extra scancodes. Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org> CC: Dmitry Torokhov <dtor@mail.ru> diff -NurpP linux-2.6.25.4-orig/drivers/input/serio/i8042-x86ia64io.h linux-2.6.25.4/drivers/input/serio/i8042-x86ia64io.h --- linux-2.6.25.4-orig/drivers/input/serio/i8042-x86ia64io.h 2008-04-17 04:49:44.000000000 +0200 +++ linux-2.6.25.4/drivers/input/serio/i8042-x86ia64io.h 2008-05-16 19:20:30.000000...
May 16, 4:08 pm 2008
Bruno
[PATCH] Input: i8042 - move Dritek quirk so it also gets app...
This patch moves the quirk from from i8042_probe() to i8042_enable_kbd_port() which is also called during resume. I think it is safe to ignore failure to enable dritek. I would also prefer not to fail complete keyboard initialisation if the extension fails. --- The Dritek quirk is also required on resume from S2RAM, doing it only at probe time is not sufficient. Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org> CC: Dmitry Torokhov <dtor@mail.ru> diff -NurpP linux-2.6....
May 16, 4:08 pm 2008
Gilles Espinasse
Re: [PATCH] drivers/net: remove network drivers' last few us...
----- Original Message ----- From: "Alan Cox" <alan@lxorguk.ukuu.org.uk> To: "Lennart Sorensen" <lsorense@csclub.uwaterloo.ca> Cc: "Jeff Garzik" <jeff@garzik.org>; "Kok, Auke" <auke-jan.h.kok@intel.com>; "Rick Jones" <rick.jones2@hp.com>; "Brandeburg, Jesse" <jesse.brandeburg@intel.com>; "Chris Peterson" <cpeterso@cpeterso.com>; <netdev@vger.kernel.org>; <linux-kernel@vger.kernel.org> Sent: Friday, May 16, 2008 5:10 PM Subject: Re: [PATCH] dri...
May 16, 4:08 pm 2008
David Miller
tip build broken on sparc64...
It's this pteval_t stuff, probably breaks just about every other platforms as well. Please fix this, because I'd like to work on some ftrace optimizations on sparc64, and do some testing of ftrace in general. mm/mmap.c: In function 'vm_get_page_prot_preserve': mm/mmap.c:86: error: 'pteval_t' undeclared (first use in this function) mm/mmap.c:86: error: (Each undeclared identifier is reported only once mm/mmap.c:86: error: for each function it appears in.) mm/mmap.c:86: error: expected ';' befo...
May 16, 4:07 pm 2008
Grant Likely
[RFC PATCH 0/4] Describe SPI devices in the OF device tree a...
This series is a set of changes to allow the slaves on an SPI bus to be described in the OF device tree (useful in arch/powerpc) and adds a driver that uses it (the Freescale MPC5200 SoC's SPI device). Please review and comment. David, I've included in this series my earlier patch to change modalias from a pointer to a string as one of the later patches depends on it. Cheers, g. -- Grant Likely, B.Sc. P.Eng. Secret Lab Technologies Ltd. --
May 16, 3:35 pm 2008
Jon Smirl
Re: [RFC PATCH 0/4] Describe SPI devices in the OF device tr...
Right now we have SPI hooked up to PSC3. Hardware engineer is gone but I'll see if I can get him to alter things to use the SPI controller. I have an old mail from him where he thinks the Phytec board is missing a signal needed to use the SPI controller. Is the current SPI driver working on PSC3? I have a MMC card wired up to it but I've never tried using it. I have the MPC5200 PSC SPI driver enabled and "MMC/SD over SPI" enabled in my kernel. The MMC bus gets created but there aren't any devi...
May 16, 4:27 pm 2008
Grant Likely
Re: [RFC PATCH 0/4] Describe SPI devices in the OF device tr...
While I'd appreciate the testing, I suspect that you really don't want to do that. The dedicated SPI controller isn't very good. It only does a byte at a time and so is rather slow. A PSC is SPI mode should Yes, see patch 3 in my series. the PSC SPI driver needs to do something like this. SPI busses don't really do autodetection (but It will remain as two drivers. The devices are entirely separate. I don't think putting them under a single Kconfig is needed or a good idea. They both d...
May 16, 4:48 pm 2008
Jon Smirl
Re: [RFC PATCH 0/4] Describe SPI devices in the OF device tr...
What is the device tree node for PSC3 supposed to look like when it has both serial and spi enabled? -- Jon Smirl jonsmirl@gmail.com --
May 16, 5:25 pm 2008
Grant Likely
Re: [RFC PATCH 0/4] Describe SPI devices in the OF device tr...
The *PSC3 device* cannot support both serial and SPI at the same time. Only one mode works at a time... However, *PSC3 pin group* has can be configured to route both the *PSC3 device* and the *SPI device* signal out to the board at the same time. Pin routing is not something that is described by the device tree. It's viewed as a board level initialization thing, similar to how DDR RAM initialization is viewed. Ideally, the bootloader will write the correct value into port_config for pin rout...
May 16, 5:32 pm 2008
Jon Smirl
Re: [RFC PATCH 0/4] Describe SPI devices in the OF device tr...
I need to talk to my hardware guy. He is using PSC3 for the boot console with the assumption that once booted it is ok to retask it to SPI. Serial console is only needed for software debugging. SSH works after boot and can replace the serial console. I'll trying changing my device tree entry from UART to SPI and boot. -- Jon Smirl jonsmirl@gmail.com --
May 16, 5:42 pm 2008
Grant Likely
[PATCH 4/4] [CSB] Add new mpc5200-spi (non-psc) device driver
From: Grant Likely <grant.likely@secretlab.ca> Unlike the old CSB driver, this driver uses the SPI infrastructure. Signed-off-by: Grant Likely <grant.likely@secretlab.ca> --- drivers/spi/Kconfig | 8 + drivers/spi/Makefile | 1 drivers/spi/mpc52xx_spi.c | 561 +++++++++++++++++++++++++++++++++++++++ include/linux/spi/mpc52xx_spi.h | 10 + 4 files changed, 580 insertions(+), 0 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kcon...
May 16, 3:36 pm 2008
Grant Likely
Re: [PATCH 4/4] [CSB] Add new mpc5200-spi (non-psc) device d...
er, this comment is *obviously* wrong. I'll fix it in the next version. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. --
May 16, 3:42 pm 2008
Grant Likely
[PATCH 3/4] spi: Add OF binding support for SPI busses
From: Grant Likely <grant.likely@secretlab.ca> This patch adds support for populating an SPI bus based on data in the OF device tree. This is useful for powerpc platforms which use the device tree instead of discrete code for describing platform layout. Signed-off-by: Grant Likely <grant.likely@secretlab.ca> --- Documentation/powerpc/booting-without-of.txt | 61 ++++++++++++++++++ drivers/spi/Kconfig | 4 + drivers/spi/Makefile ...
May 16, 3:36 pm 2008
Anton Vorontsov
Re: [PATCH 3/4] spi: Add OF binding support for SPI busses
No way to pass platform data... can you suggest any idea to use this for things like "[POWERPC] 86xx: mpc8610_hpcd: add support for SPI and MMC-over-SPI" I've sent just recently...? Maybe this code could do something like spi->dev.platform_data = nc->data; and board code would fill nc->data at early stages? This needs to be a convention, not just random use though.. Maybe we can expand the struct device_node to explicitly include .platform_data for such cases? Thanks, -- Anton V...
May 16, 6:03 pm 2008
Grant Likely
Re: [PATCH 3/4] spi: Add OF binding support for SPI busses
That's right. platform_data being a very driver specific thing there is no way to generically extract a pdata structure from the device tree. Instead, I'm storing the device node in archdata.of_node (line immediately above spi_register_device) so that drivers can read the device node themselves to populate a platform_device structure. Hmmm, as you say, this could end up being rather messy. However, by passing the device node pointer, the driver could extract that data on a per case basis. (ie...
May 16, 6:14 pm 2008
Anton Vorontsov
Re: [PATCH 3/4] spi: Add OF binding support for SPI busses
Sometimes it's not worth powder and shot adding OF functionality to the drivers, I2C and SPI are major examples. Another [not mmc_spi] example is drivers/input/touchscreen/ads7846.c, which is SPI driver and needs platform data. There is a board that needs this (touchscreen controller on a MPC8360E-RDK). Also there is no way to pass functions via device tree, we're always end up doing board-specific hooks in the generic drivers... Finally, let's call this platform_data and be done with it. Then ...
May 16, 6:49 pm 2008
Randy Dunlap
Re: [PATCH 3/4] spi: Add OF binding support for SPI busses
~~~ Hi, You mostly capitalize "SPI" in sentences (i.e., when it's not part of a function name or OF data), so could the 3 underlined instances of it also be all caps? Thanks, --- ~Randy --
May 16, 4:47 pm 2008
Grant Likely
Re: [PATCH 3/4] spi: Add OF binding support for SPI busses
No problem. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. --
May 16, 4:51 pm 2008
Grant Likely
[PATCH 2/4] spi: split up spi_new_device() to allow two stag...
From: Grant Likely <grant.likely@secretlab.ca> spi_new_device() allocates and registers an spi device all in one swoop. If the driver needs to add extra data to the spi_device before it is registered, then this causes problems. This patch splits the allocation and registration portions of code out of spi_new_device() and creates three new functions; spi_alloc_device(), spi_register_device(), and spi_device_release(). spi_new_device() is modified to use the new functions for allocation and ...
May 16, 3:36 pm 2008
Grant Likely
[PATCH 1/4] spi: Change modalias from a pointer to a charact...
From: Grant Likely <grant.likely@secretlab.ca> Currently, 'modalias' in the spi_device structure is a 'const char *'. The spi_new_device() function fills in the modalias value from a passed in spi_board_info data block. Since it is a pointer copy, the new spi_device remains dependent on the spi_board_info structure after the new spi_device is registered (no other fields in spi_device directly depend on the spi_board_info structure; all of the other data is copied). This causes a problem wh...
May 16, 3:36 pm 2008
previous daytodaynext day
May 15, 2008May 16, 2008May 17, 2008