login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
May
»
16
Re: [PATCH] Bsdacct: stir up comments around acct_process.
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
Randy Dunlap <randy.dunlap@...>
To: Pavel Emelyanov <xemul@...>
Cc: Andrew Morton <akpm@...>, Linux Kernel Mailing List <linux-kernel@...>
Subject:
Re: [PATCH] Bsdacct: stir up comments around acct_process.
Date: Friday, May 16, 2008 - 11:48 am
On Fri, 16 May 2008 14:54:59 +0400 Pavel Emelyanov wrote:
quoted text
> Fix the one describing what this function is and add one > more - about locking absence around pid namespaces loop. > > Signed-off-by: Pavel Emelyanov <xemul@openvz.org> > > --- > > diff --git a/kernel/acct.c b/kernel/acct.c > index 0feba97..d7b670c 100644 > --- a/kernel/acct.c > +++ b/kernel/acct.c > @@ -657,7 +657,8 @@ static void acct_process_in_ns(struct pid_namespace *ns) > } > > /** > - * acct_process - now just a wrapper around do_acct_process > + * acct_process - now just a wrapper around acct_process_in_ns, > + * which int turn is a wrapper around do_acct_process.
in
quoted text
> * > * handles process accounting for an exiting task > */ > @@ -665,6 +666,11 @@ void acct_process(void) > { > struct pid_namespace *ns; > > + /* > + * This loop is safe lockless, since current it still
is still
quoted text
> + * alive and holds its namespace, which in turn holds > + * its parent. > + */ > for (ns = task_active_pid_ns(current); ns != NULL; ns = ns->parent) > acct_process_in_ns(ns); > }
--- ~Randy --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH] Bsdacct: stir up comments around acct_process.
, Pavel Emelyanov
, (Fri May 16, 6:54 am)
Re: [PATCH] Bsdacct: stir up comments around acct_process.
, Randy Dunlap
, (Fri May 16, 11:48 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg KH
[RFC] sample kobject implementation
Greg Kroah-Hartman
[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Paul E. McKenney
[PATCH RFC 2/9] RCU: Fix barriers
Joe Perches
[PATCH 011/148] include/asm-x86/bug.h: checkpatch cleanups - formatting only
git
:
linux-netdev
:
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 15/37] dccp: Set per-connection CCIDs via socket options
Linus Torvalds
Re: [GIT]: Networking
Jeff Garzik
Re: [PATCH] drivers/net: remove network drivers' last few uses of IRQF_SAMPLE_RANDOM
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
1 user
and
654 guests
online.
Online users
shiatsumassager
Syndicate