Home » Mailing list archives » linux-kernel » 2008 » May » 15

[PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffies() ???

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Christophe Jaillet <christophe.jaillet@...>
To: cj <christophe.jaillet@...>, linux <linux-kernel@...>, <florian.fainelli@...>, <netdev@...>
Subject: [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffies() ???
Date: Thursday, May 15, 2008 - 5:26 pm

From: Christophe Jaillet <christophe.jaillet@wanadoo.fr>

Hi, here is a patch against linux/drivers/net/r6040.c.

Compared to other places in the kernel, I think that this driver misuses
the function round_jiffies.


Note: this patch is based on 'linux-2.6.25.tar.bz2'

Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>

---

--- linux 2.6.25/drivers/net/r6040.c	2008-05-15 23:21:28.000000000 +0200
+++ linux 2.6.25/drivers/net/r6040.c.cj	2008-05-15 22:16:44.000000000 +0200
@@ -733,7 +733,7 @@ static void r6040_timer(unsigned long da
 	}
 
 	/* Timer active again */
-	mod_timer(&lp->timer, jiffies + round_jiffies(HZ));
+	mod_timer(&lp->timer, round_jiffies(jiffies + HZ));
 }
 
 /* Read/set MAC address routines */


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffies()..., Christophe Jaillet, (Thu May 15, 5:26 pm)
Re: [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffi..., Jeff Garzik, (Wed Jun 11, 10:50 pm)
Re: [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffi..., Arjan van de Ven, (Thu May 15, 5:43 pm)
Re: [PATCH 1/1] /drivers/net/r6040.c: bad use of round_jiffi..., Florian Fainelli, (Thu May 15, 5:31 pm)