Hi James, Andrew,

Here is a patch to remove the automatic "select" of scsi_dh for
dm-multipath.

Sorry about the mishap.

chandra
On Thu, 2008-05-15 at 15:46 +0100, James Bottomley wrote:
quoted text
> On Wed, 2008-05-14 at 14:13 -0700, Randy Dunlap wrote:
> > On Wed, 14 May 2008 01:01:29 -0700 Andrew Morton wrote:
> > 
> > > 
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.26-rc2/2.6.26-rc2-mm1/
> > 
> > SCSI_DH has some problems when CONFIG_SCSI=n:
> > 
> > drivers/built-in.o: In function `activate_path':
> > dm-mpath.c:(.text+0x18a292): undefined reference to `scsi_dh_activate'
> > drivers/built-in.o: In function `multipath_ctr':
> > dm-mpath.c:(.text+0x18a6f0): undefined reference to `scsi_dh_handler_exist'
> > make[1]: *** [.tmp_vmlinux1] Error 1
> > 
> > 
> > #
> > # SCSI device support
> > #
> > CONFIG_RAID_ATTRS=y
> > # CONFIG_SCSI is not set
> > # CONFIG_SCSI_DMA is not set
> > # CONFIG_SCSI_NETLINK is not set
> > CONFIG_SCSI_DH=y
> > CONFIG_SCSI_DH_RDAC=y
> > CONFIG_SCSI_DH_HP_SW=y
> > CONFIG_SCSI_DH_EMC=y
> 
> This is one more of those annoying selects.  The SCSI_DH Kconfig file is
> correctly dependent on SCSI:
> 
> menuconfig SCSI_DH
> 	tristate "SCSI Device Handlers"
> 	depends on SCSI
> 	default n
> 	help
> 
> but we've also got a select in md/Kconfig:
> 
> config DM_MULTIPATH
> 	tristate "Multipath target"
> 	depends on BLK_DEV_DM
> 	select SCSI_DH
> 
> Which ignores the dependency.
> 
> My best guess for fixing this is either to make the select a depends or
> just drop it altogether (after all, it's possible to have multipath on
> non-SCSI devices).
> 
> James
> 
>