Home » Mailing list archives » linux-kernel » 2008 » May » 15

Re: [PATCH] zd1211rw: Use DMA-aware buffer for usb transfer

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: John W. Linville <linville@...>
To: Atsushi Nemoto <anemo@...>
Cc: Daniel Drake <dsd@...>, Ulrich Kunitz <kune@...>, <linux-wireless@...>, <linux-kernel@...>
Subject: Re: [PATCH] zd1211rw: Use DMA-aware buffer for usb transfer
Date: Thursday, May 15, 2008 - 3:16 pm

On Fri, May 16, 2008 at 12:12:15AM +0900, Atsushi Nemoto wrote:

Nemoto,

This looks like a reasonable fix to me.  I would prefer to see a
comment in the code indicating why you are reusing the "p" buffer
instead of simply using "ret" directly.  Also, I think the style
suggestion by Michael Buesch would make the code appear more idiomatic
as well.

Thanks!

John
-- 
John W. Linville
linville@tuxdriver.com
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] zd1211rw: Use DMA-aware buffer for usb transfer, Atsushi Nemoto, (Thu May 15, 11:12 am)
Re: [PATCH] zd1211rw: Use DMA-aware buffer for usb transfer, John W. Linville, (Thu May 15, 3:16 pm)
Re: [PATCH] zd1211rw: Use DMA-aware buffer for usb transfer, Atsushi Nemoto, (Fri May 16, 4:27 am)
Re: [PATCH] zd1211rw: Use DMA-aware buffer for usb transfer, Michael Buesch, (Thu May 15, 11:42 am)