Re: Sparse annotation for "context imbalance" false positives?

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Roland Dreier <rdreier@...>
Cc: <linux-kernel@...>, <linux-sparse@...>, David Brownell <david-b@...>
Date: Thursday, May 15, 2008 - 4:54 am

You could, for example, insert this:

cq *recv_cq)
		{
			 /* pretend to have acquired both for sparse */=09
			__acquire(&recv_cq->lock);
		}

and then declare that you take "both" locks. Not sure if that will bite
you in the callers again though.

The exact syntax is still a bit under discussion though, whether to use
&recv_cq->lock or leave out the "&" there, I'm favouring the approach
with & but the kernel uses no & in some places.

johannes
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Sparse annotation for "context imbalance" false positives?, Roland Dreier, (Wed May 14, 11:16 pm)
Re: Sparse annotation for "context imbalance" false positives?, Johannes Berg, (Thu May 15, 4:54 am)