login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
May
»
15
Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers to fix more potential unaligned issues.
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Jie Zhang <jie.zhang@...>
To: Oliver Neukum <oliver@...>
Cc: Bryan Wu <cooloney@...>, <harvey.harrison@...>, <david-b@...>, <greg@...>, <linux-usb@...>, <linux-kernel@...>
Subject:
Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers to fix more potential unaligned issues.
Date: Thursday, May 15, 2008 - 4:03 am
Oliver Neukum wrote:
quoted text
> Am Donnerstag 15 Mai 2008 08:19:24 schrieb Bryan Wu: >> --- a/drivers/usb/host/uhci-hub.c >> +++ b/drivers/usb/host/uhci-hub.c >> @@ -253,7 +253,7 @@ static int uhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue, >> switch (typeReq) { >> >> case GetHubStatus: >> - *(__le32 *)buf = cpu_to_le32(0); >> + put_unaligned_le32(0, buf); > > What is supposed to make all these changes a good idea? >
Since buf might not be 4-byte aligned. Jie --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers to f...
, Bryan Wu
, (Thu May 15, 2:19 am)
Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers ...
, Andrew Morton
, (Thu May 15, 8:05 pm)
Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers ...
, Harvey Harrison
, (Thu May 15, 11:37 am)
Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers ...
, Oliver Neukum
, (Thu May 15, 3:40 am)
Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers ...
, Jie Zhang
, (Thu May 15, 4:03 am)
Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers ...
, Oliver Neukum
, (Thu May 15, 4:36 am)
Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers ...
, Jie Zhang
, (Thu May 15, 5:15 am)
Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers ...
, Bryan Wu
, (Thu May 15, 5:54 am)
Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers ...
, Alan Stern
, (Thu May 15, 10:28 am)
[PATCH] usb: file-storage.c use unaligned access helpers
, Harvey Harrison
, (Thu May 15, 8:33 pm)
Re: [PATCH] usb: file-storage.c use unaligned access helpers
, Alan Stern
, (Fri May 16, 10:32 am)
[RFC-PATCH] lib: add byteorder helpers for the aligned case
, Harvey Harrison
, (Fri May 16, 2:09 pm)
Re: [RFC-PATCH] lib: add byteorder helpers for the aligned c...
, Alan Stern
, (Fri May 16, 8:35 pm)
Re: [RFC-PATCH] lib: add byteorder helpers for the aligned c...
, Harvey Harrison
, (Fri May 16, 8:37 pm)
Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers ...
, Oliver Neukum
, (Thu May 15, 8:19 am)
Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers ...
, David Brownell
, (Thu May 15, 9:03 am)
Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers ...
, Oliver Neukum
, (Thu May 15, 9:27 am)
Re: [PATCH 1/1] [usb/host]: use get/put_unaligned_* helpers ...
, Bryan Wu
, (Thu May 15, 4:09 am)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Christoph Lameter
Re: [RFC 00/15] x86_64: Optimize percpu accesses
Linus Torvalds
Re: [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in
Greg Kroah-Hartman
[PATCH 005/196] Chinese: add translation of SubmittingDrivers
Bart Van Assche
Integration of SCST in the mainstream Linux kernel
git
:
openbsd-misc
:
linux-netdev
:
David Miller
[GIT]: Networking
David Miller
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Christoph Hellwig
Re: [PATCH 06/32] IGET: Mark iget() and read_inode() as being obsolete [try #2]
Gerrit Renker
[PATCH 26/37] dccp: Integration of dynamic feature activation - part 1 (socket set...
Colocation donated by:
Who's online
There are currently
5 users
and
523 guests
online.
Online users
dogbehavior
drewsbonanza
paipailee32s
zeekec
olivdecka
Syndicate