Grr. Somebody isn't following the nice rules we have and that git
encourages: make a commit message be a nice "one-line header" with the
more complete explanation separated by an empty line (and with nice
line-breaks etc).
IOW, womebody has bad habits from SCM systems that didn't have good
visualization tools, so likely nobody actually looked at the messages
anyway.
In fact, looking closer, I don't even know how you did that. The thing
must have been forwarded as email, because the author is Jim Meyering, but
it's been forwarded through Andrew etc, so I bet the message was fine at
some point. And all the git email-application tools do the rigth thing.
Anyway, I don't *quite* care enough to ask you to re-do this, and I merged
it, but I do actually enjoy the fact that our commit messages are
generally pretty readable, and the one-liner header rule means that gitk
and various shortlog tools all give nice summaries too.
So please look out for this in the future.
There are other commits that don't follow the rules, btw: you've applied
patches from others that have the rigth Sign-off's from the authors, but
you should sign off yourself, not just ack them. By actually taking that
thing and committing it, you're doing more than ack'ing somebody elses
work.
I know it isn't really a big deal, especially with those things mostly
being pretty trivial, but I'd rather nip these issues in the bud than have
it come back when it actually might matter.
Linus
--
