linux-kernel mailing list

FromSubjectsort iconDate
Nate Case
[PATCH] leds: Add support for Philips PCA955x I2C LED drivers
This driver supports the PCA9550, PCA9551, PCA9552, and PCA9553 LED driver chips. Signed-off-by: Nate Case <ncase@xes-inc.com> --- drivers/leds/Kconfig | 8 + drivers/leds/Makefile | 1 + drivers/leds/leds-pca955x.c | 384 +++++++++++++++++++++++++++++++++++++++++++ include/linux/leds.h | 14 ++ 4 files changed, 407 insertions(+), 0 deletions(-) create mode 100644 drivers/leds/leds-pca955x.c diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 86...
May 14, 7:47 pm 2008
Randy Dunlap
reiserfs BUG in 2.6.26-rc2-mm1
This is blocksize=1024 bytes, data=ordered. On x86_64. ------------[ cut here ]------------ kernel BUG at fs/reiserfs/journal.c:1414! invalid opcode: 0000 [1] SMP last sysfs file: /sys/devices/pci0000:40/0000:40:0c.0/0000:41:00.0/0000:42:08.0/class CPU 3 Modules linked in: reiserfs parport_pc lp parport tg3 cciss ehci_hcd ohci_hcd uhci_hcd [last unloaded: xfs] Pid: 7153, comm: fsx-linux Not tainted 2.6.26-rc2-mm1 #1 RIP: 0010:[<ffffffffa0073d35>] [<ffffffffa0073d35>] :reiserfs:flus...
May 14, 7:50 pm 2008
Greg KH
[PATCH] Input: add appleir USB driver
From: Greg Kroah-Hartman <gregkh@suse.de> This driver was originally written by James McKenzie but forward ported and cleaned up by me to get it to work with modern kernel versions. Tested on my mac mini and it actually works! Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- Jiri, is it ok for this quirks addtion to go through Dmitry's triee? Or do you want me to split it out into two different patches? Dmitry, is this ok to go through your tree? Or I can take it as w...
May 14, 6:15 pm 2008
Matthew Garrett
Re: [PATCH] Input: add appleir USB driver
Minor nit, but it's supported on all the desktop Intel Macs and not just the Mini. -- Matthew Garrett | mjg59@srcf.ucam.org --
May 14, 7:27 pm 2008
Greg KH
Re: [PATCH] Input: add appleir USB driver
I know nothing about that device, sorry. I think it is a totally Ah, didn't realize that, nice to know, we should have a wider userbase then :) thanks, greg k-h --
May 14, 7:49 pm 2008
Sitsofe Wheeler
BUG: sleeping function called from invalid context when hibe...
When using the linux-next kernel from 13 May 2008 I see the following in the logs when resuming from hibernate (system is Ubuntu 7.10): [ 3283.928033] BUG: sleeping function called from invalid context at kernel/rwsem.c:21 [ 3283.928033] in_atomic():0, irqs_disabled():1 [ 3283.928033] 3 locks held by hibernate.sh/5892: [ 3283.928033] #0: (&buffer->mutex){--..}, at: [<c01958e3>] sysfs_write_file+0x25/0xdf [ 3283.928033] #1: (pm_mutex){--..}, at: [<c013d6c1>] hibernate+0x10/0x1...
May 14, 6:08 pm 2008
Rafael J. Wysocki
Re: BUG: sleeping function called from invalid context when ...
Something in the PCI department attempted to take a lock with interrupts disabled, but that lock had previously been held with interrupts enabled, or so it seems. That something was called from pci_device_resume_early and it was a VIA quirk, AFAICS. I always need some help from people who actually understand these messages, Thanks, Rafael --
May 14, 6:27 pm 2008
Andrew Morton
Re: BUG: sleeping function called from invalid context when ...
On Thu, 15 May 2008 00:27:52 +0200 That's the device_power_up() "Must be called with interrupts disabled" thing. We break it again and again. --
May 14, 6:52 pm 2008
Alan Cox
[PATCH] mm: Fix atomic_t overflow in vm
From: Alan Cox <alan@redhat.com> The atomic_t type is 32bit but a 64bit system can have more than 2^32 pages of virtual address space available. Without this we overflow on ludicrously large mappings --- fs/proc/proc_misc.c | 2 +- include/linux/mman.h | 4 ++-- mm/mmap.c | 4 ++-- mm/nommu.c | 4 ++-- mm/swap.c | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/fs/proc/proc_misc.c b/fs/proc/proc_misc.c index 74a...
May 14, 5:33 pm 2008
Alan Cox
Re: [PATCH] mm: Fix atomic_t overflow in vm
On Wed, 14 May 2008 22:33:03 +0100 Umm need to adjust the template: Add Signed-off-by: Alan Cox <alan@redhat.com> --
May 14, 5:37 pm 2008
Franck Bui-Huu
[PATCH 1/2] Split list.h and move rcu-protected lists into r...
From: Franck Bui-Huu <fbuihuu@gmail.com> This patch moves rcu-protected lists from list.h into a new header file rculist.h. This is done because list are a very used primitive structure all over the kernel and it's currently impossible to include other header files in this list.h without creating some circular dependencies. For example, list.h implements rcu-protected list and uses rcu_dereference() without including rcupdate.h. It actually compiles because users of rcu_dereference() are...
May 14, 5:24 pm 2008
Franck Bui-Huu
[PATCH 2/2] rculist.h: use the rcu API
From: Franck Bui-Huu <fbuihuu@gmail.com> This patch makes almost all list mutation primitives use rcu_assign_pointer(). The main point of this being readability improvement. Signed-off-by: Franck Bui-Huu <fbuihuu@gmail.com> --- include/linux/rculist.h | 23 +++++++++-------------- 1 files changed, 9 insertions(+), 14 deletions(-) diff --git a/include/linux/rculist.h b/include/linux/rculist.h index e673c26..52cee71 100644 --- a/include/linux/rculist.h +++ b/include/linux/rcu...
May 14, 5:26 pm 2008
Justin Mattock
startx results in a blank screen
Hello; I've compiled the latest git 2.6.26-rc2-** and really like what I see and feel(heat and noise) the problem I have is I'm forced to use 3rd party video drivers for dri : - ( So with this in mind I'm trying to compile my video card module, and am confused is to as or why startx results in a blank screen!! I've reverted drm and agpgart, and also tried to convert the video module to use drm_minor(drmP.h), but still the same results, Where in the kernel might I find some useful info on why st...
May 14, 5:16 pm 2008
Bartlomiej Zolnierki...
[git patches] IDE fixes
- disable Virtual DMA support in CS5520 host driver for now (it causes weird system lockups, thanks to TAKADA Yoshihito for reporting the issue) - fix up SWARM IDE for recent IDE core changes (Maciej W. Rozycki) - few obvious/trivial fixes for ALiM15x3 host driver - couple of obvious ide/Kconfig fixes - some code can be static now (Adrian Bunk) Linus, please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: drivers/ide/...
May 14, 5:18 pm 2008
Greg KH
[PATCH] USB: add Sensoray 2255 v4l driver
From: Dean Anderson <dean@sensoray.com> This driver adds support for the Sensoray 2255 devices. It was primarily developed by Dean Anderson with only a little bit of guidance and cleanup by Greg. From: Dean Anderson <dean@sensoray.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/media/video/Kconfig | 9 drivers/media/video/Makefile | 1 drivers/media/video/s2255drv.c | 2719 +++++++++++++++++++++++++++++++++++++++++ 3 files changed, 2729 i...
May 14, 4:59 pm 2008
Maxim Levitsky
Re: [linux-pm] [PATCH -mm] kexec jump -v9
First of all S4 ACPI code turns some leds on some systems, cosmetic thing, but still nice. Secondary, what about wakeup devices? Hardware can disable some devices in S5 while leave them running in S4 on my system for example network card will do WOL in S4, but to make it WOL in S5 I have to turn a specific option in BIOS. While my system doesn't have this, it isn't uncommon for system to leave USB ports running so one can turn the PC with keyboard/mouse even in S4. in S5 those ports will probab...
May 14, 4:41 pm 2008
Eric W. Biederman
Re: [linux-pm] [PATCH -mm] kexec jump -v9
Yes. S4 looks interesting. Especially the weird fans don't work on restore from S5 case. S4 still appears to be a premature optimization, that ads lots of complexity and reduces the reliability of the code. Software hibernation to disk should be a rock solid proposition, that needs little if any cooperation from drivers, and it should work on every box, because fundamentally it is hardware agnostic. The only cooperation we need from drivers is for devices that we can't tolerate at upper l...
May 14, 7:34 pm 2008
Adrian Bunk
[2.6 patch] irnet_irda.c must #include <asm/unaligned.h>
This patch fixes the following compile error caused by commit 332223831e86b2e17b48b4afafad07d8e3b73861 (irda: Fix a misalign access issue. (v2)): &lt;-- snip --&gt; ... CC net/irda/irnet/irnet_irda.o /home/bunk/linux/kernel-2.6/git/linux-2.6/net/irda/irnet/irnet_irda.c: In function ‘irnet_discovery_indication’: /home/bunk/linux/kernel-2.6/git/linux-2.6/net/irda/irnet/irnet_irda.c:1676: error: implicit declaration of function ‘get_unaligned’ make[4]: *** [net/irda/irnet/irnet_ird...
May 14, 4:27 pm 2008
David Miller
Re: [2.6 patch] irnet_irda.c must #include <asm/unaligned.h>
From: Adrian Bunk &lt;bunk@kernel.org&gt; Applied, thanks a lot Adrian.
May 14, 6:30 pm 2008
Randy Dunlap
Re: uwb build errors: CONFIG_PCI=n, CONFIG_USB=y
[dropped closed list: linux-uwb@bughost.org] This build error has now moved into 2.6.26-rc2-mm1 also. --- ~Randy --
May 14, 4:17 pm 2008
Greg KH
Re: uwb build errors: CONFIG_PCI=n, CONFIG_USB=y
I'm trying to get a new set of UWB patches from David that should hopefully fix this issue. thanks, greg k-h --
May 14, 5:33 pm 2008
Pradeep Singh Rautela
[PATCH 2.6.26-rc2] driver:Remove unused macro KERNEL_OFFSET
Hi, KERNEL_OFFSET macro in eni.h is not required as it is not used anywhere. Remove the unused macro from eni.h header file. Signed-off-by: Pradeep Singh &lt;rautelap@gmail.com&gt; --- drivers/atm/eni.h | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/atm/eni.h b/drivers/atm/eni.h index d04fefb..e4c9525 100644 --- a/drivers/atm/eni.h +++ b/drivers/atm/eni.h @@ -18,7 +18,6 @@ #include "midway.h" -#define KERNEL_OFFSET 0xC0000000 /* kernel 0x0 is at ph...
May 14, 4:10 pm 2008
Francis Moreau
How to avoid data copies in a driver ?
Hello, I'd like to optimize my driver, which receives data through a fifo and gives them to a user space application. In turns this application moves this data into a file. To avoid several useless copies, I'd like the application to pass to the driver a file descriptor (?) to the driver and then the driver can directly move the received data to that file. Could anybody give me some example of such scheme ? Thanks, -- Francis --
May 14, 3:54 pm 2008
linux-os (Dick Johnson)
Re: How to avoid data copies in a driver ?
You memory-map the data. Impliment mmap() in your driver. You can also impliment poll() { select() } so your application knows when new data are available. You cannot use a user-mode file-descriptor in the kernel. Cheers, Dick Johnson Penguin : Linux version 2.6.22.1 on an i686 machine (5588.29 BogoMips). My book : http://www.AbominableFirebug.com/ _ **************************************************************** The information transmitted in this message is confidential and may b...
May 14, 5:23 pm 2008
Lennart Sorensen
Re: How to avoid data copies in a driver ?
If the application memory mapped the file, would it be able to simply pass a pointer to that mapped file as part of the call to the driver and the driver would place the data directly at the requested location which would then be directly to the file? -- Len Sorensen --
May 14, 4:02 pm 2008
Lee Howard
troubleshooting/debugging hard locks
(Please reply also directly to my e-mail address since I am not subscribed to the list.) Hello, I am using Fedora 9 (and have been for the last few weeks of the "preview" period... constantly updating if possible) and testing for a fax server using Mainpine IQ Express (PCIe) multi-modem fax cards (they use the 8250 serial driver). My testing involves queuing up and sending 2000 fax jobs using HylaFAX+ 5.2.4 to send out on two ports (1000 jobs on each port) of a 4-port card - receiving t...
May 14, 3:27 pm 2008
Ray Lee
Re: troubleshooting/debugging hard locks
There's something called the NMI watchdog, that will print debugging messages out if it finds the system has hard locked. The short version is that you should add "nmi_watchdog=1" (no quotes) to the line in GRUB that has the kernel options. That assumes you have an APIC on the system. If that's not the case (you're on Uniprocessor, and no APIC) then you can try nmi_watchdog=2 instead. That'll only work on some systems, though. Better docs (than my cheesy writeup) are in Documentation/nmi_watchdog.txt in t...
May 14, 6:43 pm 2008
Zan Lynx
Re: troubleshooting/debugging hard locks
I was once told to add these to the kernel command line as well when using NMI watchdog and they do seem to help it trigger more reliably:=20 "idle=3Dpoll nohz=3Doff" --=20 Zan Lynx &lt;zlynx@acm.org&gt;
May 14, 7:42 pm 2008
Alok Kataria
Re: Kernel hangs in SMP + VMware environment.
On Wed, May 14, 2008 at 4:00 AM, Tetsuo Handa Hi Tetsuo, Can you try the patch attached with this mail, I made this on top of 2.6.24.7 but should fit on any other 2.6.24 based distro kernel. If the attached patch still gives you the same problem, please send me your config file and the boot time dmesg's. Thanks, Alok
May 14, 2:30 pm 2008
Robert P. J. Day
[PATCH] Remove final references to deprecated, unreferenced...
Now that the final references to the deprecated TOPDIR are gone, it seems safe to remove its definition. Signed-off-by: Robert P. J. Day &lt;rpjday@crashcourse.ca&gt; --- diff --git a/Makefile b/Makefile index 3140145..2f2bf3e 100644 --- a/Makefile +++ b/Makefile @@ -148,15 +148,13 @@ _all: modules endif srctree := $(if $(KBUILD_SRC),$(KBUILD_SRC),$(CURDIR)) -TOPDIR := $(srctree) -# FIXME - TOPDIR is obsolete, use srctree/objtree objtree := $(CURDIR) src := $(srctree) obj ...
May 14, 2:25 pm 2008
Ingo Molnar
[announce] "kill the Big Kernel Lock (BKL)" tree
As some of the latency junkies on lkml already know it, commit 8e3e076 ("BKL: revert back to the old spinlock implementation") in v2.6.26-rc2 removed the preemptible BKL feature and made the Big Kernel Lock a spinlock and thus turned it into non-preemptible code again. This commit returned the BKL code to the 2.6.7 state of affairs in essence. Linus also indicated that pretty much the only acceptable way to change this (to us -rt folks rather unfortunate) latency source and to get rid of th...
May 14, 1:49 pm 2008
Linus Torvalds
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
Ok, so I'm obviously happy. This is exactly the kind of thing I would want to see. That said, the way it is now set up, it's unreasonable to merge anything directly, and while I can cherry-pick obvious fixes this way, I do think we could do things better. It should be possible to set things up so that it's a config option, and we can mark it EXPERIMENTAL but still merge it into the standard kernel, so that we'd have the debug stuff there. That would get a lot more coverage, especiall...
May 14, 2:41 pm 2008
Ingo Molnar
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
yeah. This is just a first approximation. It might be v2.6.27 stuff, if hm, we'll got more ideas about other debug helpers, but i dont think warning in the scheduler is realistic or useful: lots and lots of code _does_ reschedule with the BKL held and always did - we never knew this before in a reliable way due to the auto-release. Sleeping locks that purely nest inside the BKL are the norm in the VFS, in the tty code and in most other places - they should be fine and are frequently take...
May 14, 3:41 pm 2008
Frederik Deweerdt
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
Hi Ingo, Must be a typo? Regards, Frederik --
May 14, 4:05 pm 2008
Andi Kleen
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
It's a reasonable start, but have you considered doing this work in tree instead? As in just add all the warnings, but don't actually change the semantics yet. I suspect you would get far more users this way and the work would go faster. It would be reasonable to enable this in -mm if it the warnings are not too intrusive (self disable itself etc.) Also for fixing the ioctls I'm not sure that dynamic instrumentation will really work because it would be tough to execute them all. I suspect ...
May 14, 2:30 pm 2008
Alan Cox
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
Most of the legacy users inflict that locking on other code - eg the ISN use of the BKL directly impacts on the tty layer work. --
May 14, 5:00 pm 2008
Andi Kleen
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
So you just stick unlock_kernel()/lock_kernel() around the call to TTY (or similar to the entry points) -Andi --
May 14, 5:13 pm 2008
H. Peter Anvin
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
... assuming that the ISDN code doesn't assume lock continuity across the TTY call. -hpa --
May 14, 5:16 pm 2008
Alan Cox
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
And procfs and between the tty and the net config code and ... Keeping the BKL just in legacy places doesn't work. A counting mutex (ie one you can self multi-lock) might be very useful to fix some of these however as once we push it down to the point of being a driver specific lock we can just give it a driver mutex --
May 14, 5:17 pm 2008
Alan Cox
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
&gt; Most? It isn't that simple - I've spent a good deal of time working on it. There are lots of paths that rely on interactions between modules. Eg we found stuff racing between the pid structs tty internals and procfs that happened to be saved by the BKL. That in itself is a problem Ingo's stuff won't help with: We have lots of "magic" accidental, undocumented and pot luck BKL locking semantics between subsystems that are not even visible. --
May 14, 5:19 pm 2008
Linus Torvalds
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
The good news is that I suspect they are going away. It probably is mainly tty and /proc by now, and /proc is pretty close to done. It's hard to have too many inter-module dependencies when most of the core modules no longer even take the kernel lock any more. In the VFS layer, we still have - the ioctl thing, obviously. That's just mind-numbing "move things down", not hard per se. But there's a *lot* of them (and I suspect the huge majority of them don't actually need it, sin...
May 14, 5:45 pm 2008
Andi Kleen
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
Character devices in general. And what's pretty nasty is that some interfaces force BKL still, so - fasync [had some patches for "fasync_locked", not sure if it's worth it] - character device open I tried to recruit kernel janitors some time ago to just do all the ioctl -&gt; ioctl_unlocked/explicit lock_kernel changes. There were a few patches generated but the effort died down then. BTW for ioctl the dynamic instrumentation method proposed also won't work because it's basically ...
May 14, 6:03 pm 2008
Jonathan Corbet
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
There's also every char device open() method - a rather long list in its own right. I'd be surprised if one in ten of them really needs it, but one has to look... I've been looking at the chrdev code anyway, and pondering on how this might be addressed. Here's some thoughts on alternatives, I'd be curious what people think: 1: We could add an unlocked_open() to the file_operations structure; drivers could be converted over as they are verified not to need the BKL on open. Disadvantage...
May 14, 5:45 pm 2008
Linus Torvalds
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
I don't think there are *that* many. I found only 83 instances of "register_chrdev()" in the kernel, so the open methods should be pretty limited. Of course, some open methods call other sub-registrations, but you'd start off by moving the lock_kernel() down just *one* stage. So it literally should be: - remove one lock_kernel/unlock_kernel pair in fs/char_dev.c - add max 83 pairs in the places that register those things I really don't think it's worth the pain. See above. The numb...
May 14, 5:56 pm 2008
Jonathan Corbet
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
There's the drivers calling cdev_add() directly as well - another This is all certainly doable, but it leaves me with one concern: there will be no signal to external module maintainers that the change needs to be made. So, beyond doubt, quite a few of them will just continue to be shipped unfixed - and they will still run. If any of them actually *need* the BKL, something awful may happen to somebody someday. jon --
May 14, 6:07 pm 2008
Linus Torvalds
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
External modules have bugs because interfaces change. Film at 11. It's true, but it definitely shouldn't keep us from just doing it. Especially since well-maintained external modules (ie the authors follow big discussions like this) can just take the kernel lock regardless of kernel version, since it won't even be broken with old kernels. Of course, well-maintained kernel modules wouldn't depend on the BKL in the first place. Oh, well. Linus --
May 14, 6:14 pm 2008
Andi Kleen
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
In general when changing semantics drastically you should force compile errors by renaming the respective entry point. That has been the standard Linux method for this for years. I doubt it will be very interesting, but it would be useful. The goal less being to get rid of BKL in old drivers, but not requiring BKL in new drivers. Basically all BKL assumptions in interfaces really should go. -Andi --
May 14, 6:11 pm 2008
Linus Torvalds
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
No, we really do want to get rid of BKL in old drivers too. Or at least in the interfaces. Linus --
May 14, 6:16 pm 2008
Andi Kleen
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
In the interfaces definitely yes and all subsystems should have their own lock_kernel calls, but why in the old drivers? For those it's very unlikely they are used on any SMP system anyways (e.g. anything depending on CONFIG_ISA) or if they do only on 2 CPU systems. Of course if you can find someone to do the work it wouldn't be bad, just wouldn't seem like a particularly useful investment of time to me. Also it would be bad if the people who did such conversions didn't actually test it and th...
May 14, 6:21 pm 2008
Alan Cox
Re: [announce] "kill the Big Kernel Lock (BKL)" tree
Its beginning to sound like should start 2.7 ;) Alan --
May 14, 5:39 pm 2008
previous daytodaynext day
May 13, 2008May 14, 2008May 15, 2008