There are users, who would like to use lock_page_killable() in modules,
so far there are no users in kernel, but for consistency it can be
exported without them.
Not that it is particulary needed, but copying page_waitqueue() in
modules is frowned upon and unlikely to be exported either.
As a side note, do we want interruptible and time limited locking for
those who knows what is being done?
Signed-off-by: Evgeniy Polyakov <email@example.com>
diff --git a/mm/filemap.c b/mm/filemap.c
index 07e9d92..0a4fea5 100644
@@ -610,6 +610,7 @@ int __lock_page_killable(struct page *page)
return __wait_on_bit_lock(page_waitqueue(page), &wait,
* __lock_page_nosync - get a lock on the page, without calling sync_page()
On Wed, 14 May 2008 18:11:58 +0400
Missing information #1: Who are the users and what are the URLs to the
_GPL - or better yet this could be added *when* we have an actual in tree
user who really needs it and can show it is appropriate to export.
That'll also save Adrian from removing it again ;)
POHMELFS wants to use that in two places: one to lock page in writeback,
another one is about second part of the message - it waits for timeout
or signal or locks the page. If page can not be locked, it performs own
steps, not sleeps forever...
POHMELFS is a high performance network filesystem, homepage for interested
or yesterdays mail to mail lists:
I copied page_waitqueue() and use wait_on_bit() logic myself.
No problem wiht GPL-only exporting, but carring it over the whole
release means no ability to build out-of-tree module.
Actually what I want to hear, is that it is needed or not at all...