Re: [PATCH] checkpatch: update the 80-char-line check to allow for long strings

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Andres Salomon

Subject: Re: [PATCH] checkpatch: update the 80-char-line check to allow for long strings

Date: Wednesday, May 14, 2008 - 9:23 am

On Wed, 14 May 2008 16:59:26 +0100
Andy Whitcroft <apw@shadowen.org> wrote:

quoted text> On Wed, May 14, 2008 at 10:49:38AM -0400, Andres Salomon wrote:
> > On Wed, 14 May 2008 09:49:06 +0200
> > Peter Zijlstra <peterz@infradead.org> wrote:
> > 
[...]
quoted text> > 
> > The point is that we tell people to make sure that their patches are
> > checkpatch-clean.  Let's make the tool reflect what we're actually
> > looking for.
> 
> We did have a mini discussion on this when Ingo suggested allowing the
> strings to run off the end of the line so that grep would work.  I did
> put together a patch then for this.  There was no real response to the
> suggestion we should take that recommendation into CodingStyle and
> thus into checkpatch.
> 
> -apw

I've yet to hear anyone say that this idea is awful...
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] checkpatch: update the 80-char-line check to allow ..., Andres Salomon, (Tue May 13, 9:53 pm)

Re: [PATCH] checkpatch: update the 80-char-line check to a ..., Peter Zijlstra, (Wed May 14, 12:49 am)

Re: [PATCH] checkpatch: update the 80-char-line check to a ..., Andres Salomon, (Wed May 14, 7:49 am)

Re: [PATCH] checkpatch: update the 80-char-line check to a ..., Andy Whitcroft, (Wed May 14, 8:59 am)

Re: [PATCH] checkpatch: update the 80-char-line check to a ..., Andres Salomon, (Wed May 14, 9:23 am)

Navigation

Popular discussions


linux-kernel:
FUJITA Tomonori	Re: [Scst-devel] Integration of SCST in the mainstream Linux kernel
Uwe Kleine-König	Re: [PATCH v2] ARM: allow, but warn, when issuing ioremap() on RAM
Ingo Molnar	Re: [RFC/RFT PATCH] sched: automated per tty task groups
Ingo Molnar	Re: [GIT PULL] time.c - respin
Robin Holt	Re: [PATCH 02 of 12] Fix ia64 compilation failure because of common code include bug
git:
Mike Miller	git message
Junio C Hamano	Re: [PATCH] Detached HEAD (experimental)
Stefan Richter	Re: [kernel.org users] [RFD] On deprecating "git-foo" for builtins
A Large Angry SCM	Re: [RFC] origin link for cherry-pick and revert
Petr Baudis	Re: PPC SHA-1 Updates in "pu"
git-commits-head:
Linux Kernel Mailing List	libata: disable ATAPI AN by default
Linux Kernel Mailing List	ARM: 5905/1: ARM: Global ASID allocation on SMP
Linux Kernel Mailing List	timer: Try to survive timer callback preempt_count leak
Linux Kernel Mailing List	Documentation/timers/hpet_example.c: only build on X86
Linux Kernel Mailing List	ALSA: hda - Enable beep on Realtek codecs with PCI SSID override
linux-netdev:
Arnaldo Carvalho de Melo	Re: [PATCH 06/37] dccp: Limit feature negotiation to connection setup phase
Gerrit Renker	[PATCH 1/5] dccp: Initialisation framework for feature negotiation
Daniel Lezcano	getsockopt(TCP_DEFER_ACCEPT) value change
David Miller	Re: 2.6.27.18: bnx2/tg3: BUG: "scheduling while atomic" trying to ifenslave a seco...
Jeff Garzik	Re: [PATCH] drivers/net: remove network drivers' last few uses of IRQF_SAMPLE_RANDOM
openbsd-misc:
Stuart Henderson	Re: Kuro5hin: OpenBSD Founder Theo deRaadt Has Conflict of Interest With AMD
Christian Weisgerber	Re: CARP with a single public IP address
Darrin Chandler	Re: strange output on openbsd C code
Marco Peereboom	Re: OpenBSD culture?
KURS ENGLESKOG JEZIKA NA 10 CD-a	AUDIO-VIZUELNA METODA UCENJA ENGLESKOG JEZIKA na 10 CD-a

Colocation donated by:

Syndicate