Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Benjamin Thery <benjamin.thery@...>

Cc: Eric W. Biederman <ebiederm@...>, Randy Dunlap <RANDY.DUNLAP@...>, Greg KH <greg@...>, Al Viro <viro@...>, Greg KH <gregkh@...>, <linux-kernel@...>, <netdev@...>, Daniel Lezcano <dlezcano@...>, Pavel Emelyanov <xemul@...>, Serge E. Hallyn <serue@...>, Tejun Heo <htejun@...>

Subject: Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4

Date: Wednesday, May 14, 2008 - 5:56 am

On Wed, 14 May 2008 11:51:17 +0200 Benjamin Thery <benjamin.thery@bull.net> wrote:

quoted text> > uninlining sysfs_rename_dir() would be a sensible solution.
> 
> It is inlined only when CONFIG_SYSFS=n. When sysfs is enabled 
> sysfs_rename_dir() is compiled from fs/sysfs/dir.c
> 
> Uninlining it will require us to find an appropriate .c file to put it
> in: we can't put it in fs/sysfs/dir.c. It is not built if CONFIG_SYSFS 
> is disabled.

Well yes, that's the problem.  I stuck it in lib/kobject.c but ugh.

I guess we could make it a macro and quickly run away.
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 10/11] avoid kobject name conflict with different nam..., Benjamin Thery, (Tue May 6, 1:32 pm)

Re: [PATCH 10/11] avoid kobject name conflict with different..., Eric W. Biederman, (Wed May 7, 2:49 pm)

Re: [PATCH 10/11] avoid kobject name conflict with different..., Greg KH, (Wed May 7, 3:08 pm)

[PATCH] Fix kobject_rename and !CONFIG_SYSFS, Eric W. Biederman, (Thu May 8, 5:41 pm)

Re: kobject: Fix kobject_rename and !CONFIG_SYSFS, Greg KH, (Mon May 12, 6:02 pm)

Re: kobject: Fix kobject_rename and !CONFIG_SYSFS, Eric W. Biederman, (Tue May 13, 3:00 am)

Re: kobject: Fix kobject_rename and !CONFIG_SYSFS, Benjamin Thery, (Tue May 13, 10:25 am)

Re: kobject: Fix kobject_rename and !CONFIG_SYSFS, Greg KH, (Tue May 13, 12:44 pm)

Re: kobject: Fix kobject_rename and !CONFIG_SYSFS, Benjamin Thery , (Tue May 13, 3:33 pm)

Re: kobject: Fix kobject_rename and !CONFIG_SYSFS, Eric W. Biederman, (Tue May 13, 4:42 pm)

[PATCH] Fix kobject_rename and !CONFIG_SYSFS v2, Eric W. Biederman, (Tue May 13, 1:55 pm)

Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v2, Greg KH, (Tue May 13, 4:16 pm)

[PATCH] Fix kobject_rename and !CONFIG_SYSFS v3, Eric W. Biederman, (Tue May 13, 4:45 pm)

Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v3, Randy Dunlap, (Tue May 13, 5:18 pm)

[PATCH] Fix kobject_rename and !CONFIG_SYSFS v4, Eric W. Biederman, (Wed May 14, 12:39 am)

Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4, Andrew Morton, (Wed May 14, 1:03 am)

Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4, Eric W. Biederman, (Wed May 14, 5:01 am)

Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4, Andrew Morton, (Wed May 14, 5:20 am)

Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4, Benjamin Thery, (Wed May 14, 5:51 am)

Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v4, Andrew Morton, (Wed May 14, 5:56 am)

Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v2, Randy.Dunlap, (Tue May 13, 2:23 pm)

Re: [PATCH] Fix kobject_rename and !CONFIG_SYSFS v2, Eric W. Biederman, (Tue May 13, 4:43 pm)

[PATCH] wireless: Add missing locking to cfg80211_dev_rename, Eric W. Biederman, (Thu May 8, 5:30 pm)

Re: [PATCH] wireless: Add missing locking to cfg80211_dev_re..., Johannes Berg, (Thu May 8, 6:18 pm)

Re: [PATCH] wireless: Add missing locking to cfg80211_dev_re..., Serge E. Hallyn, (Thu May 8, 6:12 pm)

Re: [PATCH 10/11] avoid kobject name conflict with different..., Eric W. Biederman, (Thu May 8, 3:25 pm)

Re: [PATCH 10/11] avoid kobject name conflict with different..., Eric W. Biederman, (Wed May 7, 4:54 pm)

Re: [PATCH 10/11] avoid kobject name conflict with different..., Cornelia Huck, (Thu May 8, 4:28 am)

Re: [PATCH 10/11] avoid kobject name conflict with different..., Eric W. Biederman, (Thu May 8, 3:28 pm)

Re: [PATCH 10/11] avoid kobject name conflict with different..., Cornelia Huck, (Fri May 9, 1:35 am)

Re: [PATCH 10/11] avoid kobject name conflict with different..., Eric W. Biederman, (Fri May 9, 2:16 pm)

Navigation

Popular discussions


linux-kernel:
Amit K. Arora	[RFC] Heads up on sys_fallocate()

Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
git:

openbsd-misc:

linux-netdev:
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
David Miller	[GIT]: Networking
Matheos Worku	2.6.24 BUG: soft lockup - CPU#X

Colocation donated by:

Online users

zeekec

Syndicate