That MODULE_DESCRIPTION(MOD_DESCRIPTION) looks so redundant. [Same

for MOD_AUTHOR and MOD_LICENSE.]

Just write MODULE_DESCRIPTION("USB High Speed Option driver"), no?
Also, "Option" sounds a bit misleading. Is Option a company name,
The usual bunch of \s.. er, has this gone through checkpatch? [Seems 
You could refactor this using a static array mapping from port to

string. Same for the following three functions (hso_port_to_mux and

hso_mux_to_port).
	static const char *const names[] = {

		[HSO_PORT_xxx] = "xxx";
I would have never thought! (Also elsewhere.)
--

Can we get it into 2.6.26 - its a driver for new hardware and the driver

is going to get a clean up for 2.6.27 anyway.
Comments below are minor and I don't think blockers
So for the serial side
tty is passed why keep using serial->tty (hint: think about parallel
(else *tty->termios = *old_termios)
--

Added.
Thanks for the review, I really appreciate it.
greg k-h

--

AFAIK new drivers are OK post-rc1, since no possibility of regression

and it enables new users.
However, an exception to that might be a super-huge driver slipped in at

the last minute with no review (clearly not the case here)
	Jeff
--

Thanks, I'll provide a clean-up patch based on this review in a few

hours.
Thanks, I appreciate it.
greg k-h

--

This driver is for a number of different Option devices.  Originally

written by Option and Andrew Bird, but cleaned up massivly for

acceptance into mainline by me and others.
Many thanks to the following for their help in cleaning up the driver by

providing feedback and patches to it:

	- Paulius Zaleckas <paulius.zaleckas@teltonika.lt>

	- Oliver Neukum <oliver@neukum.org>

	- Alan Cox <alan@lxorguk.ukuu.org.uk>

	- Javier Marcet <javier@krausbeck.org>
Cc: Andrew Bird <ajb@spheresystems.co.uk>

Cc: Javier Marcet <javier@krausbeck.org>

Cc: Filip Aben <f.aben@option.com>

Cc: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>

Cc: Oliver Neukum <oliver@neukum.org>

Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
Jeff, this is an updated version from what I previously sent.  I have no

objection for this to go into 2.6.26.
 drivers/net/Makefile     |    1

 drivers/net/usb/Kconfig  |   10

 drivers/net/usb/Makefile |    1

 drivers/net/usb/hso.c    | 2836 +++++++++++++++++++++++++++++++++++++++++++++++

 4 files changed, 2848 insertions(+)
--- a/drivers/net/Makefile

+++ b/drivers/net/Makefile

@@ -236,6 +236,7 @@ obj-$(CONFIG_USB_CATC)          += usb/

 obj-$(CONFIG_USB_KAWETH)        += usb/

 obj-$(CONFIG_USB_PEGASUS)       += usb/

 obj-$(CONFIG_USB_RTL8150)       += usb/

+obj-$(CONFIG_USB_HSO)		+= usb/

 obj-$(CONFIG_USB_USBNET)        += usb/

 obj-$(CONFIG_USB_ZD1201)        += usb/
--- /dev/null

+++ b/drivers/net/usb/hso.c

@@ -0,0 +1,2836 @@

+/******************************************************************************

+ *

+ * Driver for Option High Speed Mobile Devices.

+ *

+ *  Copyright (C) 2008 Option International

+ *  Copyright (C) 2007 Andrew Bird (Sphere Systems Ltd)

+ *  			<ajb@spheresystems.co.uk>

+ *  Copyright (C) 2008 Greg Kroah-Hartman <gregkh@suse.de>

+ *  Copyright (C) 2008 Novell, Inc.

+ *

+ *  This program is fr...
[ message continues ]

applied
--

Maybe we should bump the version?
--

no it is not. That can be removed.
Regards
Marcel
--

Probably the best thing would be to drop it altogether as it doesn't

make a lot of sense to maintain it in the kernel. Also the pharscape

version will continue to live it's own life till the hso driver is fully

settled in an official kernel, so version conflicts would be bound to

happen anyway.
Regards,
Filip-
--