Re: [PATCH] HSO: add option hso driver

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Alan Cox
Date: Tuesday, May 13, 2008 - 3:27 pm

> Jeff, please queue this up for 2.6.27 if there are no problems that you

Can we get it into 2.6.26 - its a driver for new hardware and the driver
is going to get a clean up for 2.6.27 anyway.

Comments below are minor and I don't think blockers

So for the serial side

Acked-by: Alan Cox <alan@redhat.com>



tty is passed why keep using serial->tty (hint: think about parallel
hangup versus close/open)


tty cannot be NULL here



Checks one thing printks another 8)


(else *tty->termios = *old_termios)


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] HSO: add option hso driver, Greg KH, (Tue May 13, 2:51 pm)
Re: [PATCH] HSO: add option hso driver, Alan Cox, (Tue May 13, 3:27 pm)
Re: [PATCH] HSO: add option hso driver, Jeff Garzik, (Tue May 13, 4:26 pm)
Re: [PATCH] HSO: add option hso driver, Greg KH, (Tue May 13, 6:58 pm)
Re: [PATCH] HSO: add option hso driver, Greg KH, (Tue May 13, 9:52 pm)
HSO: add option hso driver, Greg Kroah-Hartman, (Tue May 13, 9:57 pm)
Re: HSO: add option hso driver, Paulius Zaleckas, (Wed May 14, 6:59 am)
Re: HSO: add option hso driver, Filip Aben, (Wed May 14, 8:12 am)
Re: [PATCH] HSO: add option hso driver, Jan Engelhardt, (Wed May 14, 8:58 am)
Re: HSO: add option hso driver, Marcel Holtmann, (Wed May 14, 10:36 am)
Re: HSO: add option hso driver, Jeff Garzik, (Wed Jun 11, 7:51 pm)