Re: [PATCH] x86: fix app crashes after SMP resume

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Glauber Costa <glommer@...>
Cc: Glauber Costa <gcosta@...>, Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>, Ingo Molnar <mingo@...>, H. Peter Anvin <hpa@...>, Theodore Ts'o <tytso@...>, Carlos R. Mafra <crmafra2@...>, Rafael J. Wysocki <rjw@...>, <linux-kernel@...>
Date: Tuesday, May 13, 2008 - 11:12 am

On Tue, 13 May 2008, Glauber Costa wrote:

You're right, something like that (but avoiding the __flush_tlb_all
on x86_64) would have been nicer; never mind, now it's going forward,
I'll leave it as is.

A bigger improvement would be to cut out all that swapper_pg_dir
to and fro, needing a global TLB flush on all cpus for each cpu.
Just have an alternate pg_dir (often already there as swsusp_pg_dir)
to point cr3 at for the bootup (or maybe it needs to be vice versa).

But that's harder to get right, and involves wider changes and much
more testing than I could afford for the bugfix.  Plus I expect it's
on your radar if not already done.

Hugh
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] x86: fix app crashes after SMP resume, Hugh Dickins, (Tue May 13, 9:26 am)
Re: [PATCH] x86: fix app crashes after SMP resume, Theodore Tso, (Wed May 14, 10:03 am)
Re: [PATCH] x86: fix app crashes after SMP resume, Carlos R. Mafra, (Tue May 13, 1:24 pm)
Re: [PATCH] x86: fix app crashes after SMP resume, Hugh Dickins, (Tue May 13, 1:47 pm)
Re: [PATCH] x86: fix app crashes after SMP resume, Ingo Molnar, (Tue May 13, 10:02 am)
Re: [PATCH] x86: fix app crashes after SMP resume, Pavel Machek, (Wed May 21, 7:16 am)
Re: [PATCH] x86: fix app crashes after SMP resume, Glauber Costa, (Tue May 13, 10:03 am)
Re: [PATCH] x86: fix app crashes after SMP resume, Hugh Dickins, (Tue May 13, 11:12 am)