Re: [PATCH] ext3/4: fix uninitialized bs in ext3/4_xattr_set_handle()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Tiger Yang
Date: Tuesday, May 13, 2008 - 12:48 am

Hi, Eric,

I don't have tesecase about this bug. I did the test manually. I use 
khexedit to confirm the attributes whether in inody or block.
The problem about this bug is we want to replace an existing attribute 
in ibody with big size value which larger than free space in ibody.
Because we didn't do block_find(), so the struct bs have not been 
initialized. Then when we try to set attribute in block by block_set(), 
we find bs->base is empty, we need alloc a new block for attributes. The 
old block pointed by i_file_acl will lost with attributes in it.

Best regards,
tiger

Eric Sandeen wrote:
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH] ext3/4: fix uninitialized bs in ext3/4_xattr_s ..., Tiger Yang, (Tue May 13, 12:48 am)
Re: [PATCH] ext3/4: fix uninitialized bs in ext3/4_xattr_s ..., Andreas Gruenbacher, (Wed May 14, 3:56 am)