Home » Mailing list archives » linux-kernel » 2008 » May » 13

Re: [PATCH 18/18] flag parameters: check magic constants

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ulrich Drepper <drepper@...>
To: David Miller <davem@...>
Cc: <akpm@...>, <linux-kernel@...>, <netdev@...>, <davidel@...>, <mtk.manpages@...>, <torvalds@...>
Subject: Re: [PATCH 18/18] flag parameters: check magic constants
Date: Tuesday, May 13, 2008 - 12:21 am

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

David Miller wrote:

Is MIPS really a problem?  The value is 0x80.  128 protocol types should
be enough.  Even if not, there is no reason why the numbers should be
consecutive.  It's easy enough to skip over a bit.  I.e., after procotol
0x7f the next one would be 0x100.

And PA seems to have gotten O_NONBLOCK wrong.  SPARC does it right AFAICS.

- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQFIKRdJ2ijCOnn/RHQRAovKAKDFz2ZJ0E2XYVu5Qn8fME+ieZZopwCgmH4D
ldfvNrhK8LdvjZzNPViILV0=
=Z9Dj
-----END PGP SIGNATURE-----
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 18/18] flag parameters: check magic constants, Ulrich Drepper, (Tue May 6, 5:18 pm)
Re: [PATCH 18/18] flag parameters: check magic constants, Andrew Morton, (Fri May 23, 1:22 am)
Re: [PATCH 18/18] flag parameters: check magic constants, Ulrich Drepper, (Fri May 23, 10:31 am)
Re: [PATCH 18/18] flag parameters: check magic constants, Andrew Morton, (Mon May 12, 11:13 pm)
Re: [PATCH 18/18] flag parameters: check magic constants, Ulrich Drepper, (Mon May 12, 11:54 pm)
Re: [PATCH 18/18] flag parameters: check magic constants, David Miller, (Tue May 13, 12:02 am)
Re: [PATCH 18/18] flag parameters: check magic constants, Andrew Morton, (Tue May 13, 1:04 am)
Re: [PATCH 18/18] flag parameters: check magic constants, Ulrich Drepper, (Tue May 13, 1:10 am)
Re: [PATCH 18/18] flag parameters: check magic constants, Andrew Morton, (Tue May 13, 1:19 am)
Re: [PATCH 18/18] flag parameters: check magic constants, Ulrich Drepper, (Tue May 13, 1:42 am)
Re: [PATCH 18/18] flag parameters: check magic constants, Andrew Morton, (Wed May 14, 12:43 am)
Re: [PATCH 18/18] flag parameters: check magic constants, Ulrich Drepper, (Tue May 13, 12:21 am)
Re: [PATCH 18/18] flag parameters: check magic constants, David Miller, (Tue May 13, 12:39 am)
Re: [PATCH 18/18] flag parameters: check magic constants, Andrew Morton, (Tue May 13, 12:01 am)
Re: [PATCH 18/18] flag parameters: check magic constants, David Miller, (Mon May 12, 11:45 pm)