login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
May
»
12
Re: [PATCH 6/6, revised] drivers/net/pppol2tp.c: remove null pointer dereference
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
[view in full thread]
From:
David Miller <davem@...>
To: <julia@...>
Cc: <netdev@...>, <jchapman@...>, <linux-kernel@...>, <kernel-janitors@...>
Subject:
Re: [PATCH 6/6, revised] drivers/net/pppol2tp.c: remove null pointer dereference
Date: Monday, May 12, 2008 - 6:44 pm
From: Julia Lawall <julia@diku.dk> Date: Mon, 12 May 2008 22:21:25 +0200 (CEST)
quoted text
> If session is NULL, it is not possible to access its name field. So I have > split apart the printing of the error message to drop the printing of the > name field in this case. > > The macro PRINTK actually only evaluates its arguments starting with the > third one if the bitwise conjunction of the first two is non-zero. > Normally, this conjunction would only be non-zero if debugging mode were > turned on, but when session is NULL, the first argument in both the old and > new code is -1, and thus the bitwise conjunction is true. Perhaps a > different strategy is desired, such as using tunnel->debug, which > session->debug is initialized to, but tunnel can also be NULL, so this does > not completely solve the problem.
...
quoted text
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied, thanks. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [thread] [
date
] [
author
]
Messages in current thread:
[PATCH 6/6, revised] drivers/net/pppol2tp.c: remove null poi...
, Julia Lawall
, (Mon May 12, 4:21 pm)
Re: [PATCH 6/6, revised] drivers/net/pppol2tp.c: remove null...
, David Miller
, (Mon May 12, 6:44 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Greg Kroah-Hartman
[PATCH 004/196] Chinese: add translation of SubmittingPatches
Rafael J. Wysocki
[Bug #11210] libata badness
Andrea Arcangeli
[PATCH 00 of 11] mmu notifier #v16
Andrew Morton
Re: -mm merge plans for 2.6.23 -- sys_fallocate
git
:
openbsd-misc
:
linux-netdev
:
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Daniel Eischen
Re: error with thread
David Miller
Re: [GIT]: Networking
Jarek Poplawski
Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Colocation donated by:
Who's online
There are currently
1 user
and
840 guests
online.
Online users
strcmp
Syndicate