Hi!

I'm getting these from rfcomm...

								Pavel

 host4: resumed
scsi 4:0:0:0: Direct-Access     OLYMPUS  C765UZ           1.00 PQ: 0 ANSI: 2
sd 4:0:0:0: [sdb] 32000 512-byte hardware sectors (16 MB)
sd 4:0:0:0: [sdb] Write Protect is off
sd 4:0:0:0: [sdb] Mode Sense: 18 00 00 08
sd 4:0:0:0: [sdb] Assuming drive cache: write through
sd 4:0:0:0: [sdb] 32000 512-byte hardware sectors (16 MB)
sd 4:0:0:0: [sdb] Write Protect is off
sd 4:0:0:0: [sdb] Mode Sense: 18 00 00 08
sd 4:0:0:0: [sdb] Assuming drive cache: write through
 sdb: sdb1
sd 4:0:0:0: [sdb] Attached SCSI removable disk
sd 4:0:0:0: Attached scsi generic sg1 type 0
usb-storage: device scan complete
hci_cmd_task: hci0 command tx timeout
usb 5-1: USB disconnect, address 2
btusb_bulk_complete: hci0 urb f6191550 failed to resubmit (19)
btusb_bulk_complete: hci0 urb f6879090 failed to resubmit (19)
btusb_send_frame: hci0 urb f6879090 submission failed
hub 1-0:1.0: unable to enumerate USB device on port 7
usb 5-1: new full speed USB device using uhci_hcd and address 4
usb 5-1: configuration #1 chosen from 1 choice
usb 5-1: New USB device found, idVendor=0a5c, idProduct=2110
usb 5-1: New USB device strings: Mfr=1, Product=2, SerialNumber=0
usb 5-1: Product: BCM2045B
usb 5-1: Manufacturer: Broadcom Corp
sysfs: duplicate filename 'rfcomm0' can not be created
------------[ cut here ]------------
WARNING: at /data/l/linux/fs/sysfs/dir.c:425 sysfs_add_one+0x85/0xa0()
Modules linked in:
Pid: 2011, comm: rfcomm Tainted: G        W 2.6.26-rc1 #289
 [<c022a2af>] warn_on_slowpath+0x5f/0x90
 [<c021c9e8>] __wake_up_common+0x48/0x70
 [<c02203e8>] __wake_up+0x38/0x50
 [<c022aa8b>] wake_up_klogd+0x3b/0x40
 [<c038510b>] ida_get_new_above+0x7b/0x180
 [<c02bd400>] sysfs_ilookup_test+0x0/0x10
 [<c0751214>] _spin_unlock+0x14/0x20
 [<c029037f>] ifind+0x8f/0xa0
 [<c022b23b>] printk+0x1b/0x20
 [<c02bd775>] sysfs_add_one+0x85/0xa0
 [<c02bdcc8>] create_dir+0x48/0x90
 [<c02bdd39>] sysfs_create_dir+0x29/0x50
 [<c0751214>] ...
[ message continues ]

Are you sure it's a regression?

Dont know if it's same bug as BUG 10341.  I just describe the problem
in bug 10341:

While a rfcomm device is opened more than once, the BUG 10341 can be triggered.

rfcomm dev reference will be held for every rfcomm_tty_open, but release_dev
 will hangup the tty and release the dev number for free use without
judge the dev->opened.

rfcomm_dev_state_change and rfcomm_tty_hangup could del the rfcomm dev
as well,  the problem is similar as above.

If the create_dev called before the last tty_close,  sysfs will
warning and create will fail.

I have a patch which don't hold the dev reference in rfcomm_tty_open,
but it need some review and test.

please see:
http://bugzilla.kernel.org/attachment.cgi?id=15746

--

[ message continues ]

No, I'm not sure it is an regression. I have not seen it in a while,

									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--

[ message continues ]