Home » Mailing list archives » linux-kernel » 2008 » May » 11

[PATCH] I2C: SiByte: Mark i2c_sibyte_add_bus() as static

Previous thread: [PATCH] I2C: SiByte: Correct a comment about frequency by Maciej W. Rozycki on Saturday, May 10, 2008 - 7:10 pm. (2 messages)

Next thread: Re: HDIO_DRIVE_CMD failed on Dell Latitude D630 by Robert Hancock on Saturday, May 10, 2008 - 10:57 pm. (2 messages)
[view original message]
From: Maciej W. Rozycki
Subject: [PATCH] I2C: SiByte: Mark i2c_sibyte_add_bus() as static
Date: Saturday, May 10, 2008 - 7:14 pm

The i2c_sibyte_add_bus() function is not called, nor meant to, from 
outside, so mark it as static; fixing a sparse warning too.

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
 It should be obvious.  Please apply.

  Maciej

patch-2.6.26-rc1-20080505-sibyte-i2c-sparse-16
diff -up --recursive --new-file linux-2.6.26-rc1-20080505.macro/drivers/i2c/busses/i2c-sibyte.c linux-2.6.26-rc1-20080505/drivers/i2c/busses/i2c-sibyte.c
--- linux-2.6.26-rc1-20080505.macro/drivers/i2c/busses/i2c-sibyte.c	2008-05-05 02:55:25.000000000 +0000
+++ linux-2.6.26-rc1-20080505/drivers/i2c/busses/i2c-sibyte.c	2008-05-11 01:11:00.000000000 +0000
@@ -132,7 +132,7 @@ static const struct i2c_algorithm i2c_si
 /*
  * registering functions to load algorithms at runtime
  */
-int __init i2c_sibyte_add_bus(struct i2c_adapter *i2c_adap, int speed)
+static int __init i2c_sibyte_add_bus(struct i2c_adapter *i2c_adap, int speed)
 {
 	struct i2c_algo_sibyte_data *adap = i2c_adap->algo_data;
 
--


[ message continues ]
[view original message]
From: Jean Delvare
Subject: Re: [PATCH] I2C: SiByte: Mark i2c_sibyte_add_bus() as static
Date: Sunday, May 11, 2008 - 2:07 am

Applied, thanks.

-- 
Jean Delvare
--


[ message continues ]
Previous thread: [PATCH] I2C: SiByte: Correct a comment about frequency by Maciej W. Rozycki on Saturday, May 10, 2008 - 7:10 pm. (2 messages)

Next thread: Re: HDIO_DRIVE_CMD failed on Dell Latitude D630 by Robert Hancock on Saturday, May 10, 2008 - 10:57 pm. (2 messages)