put_char() can return an uninitialized value of 'ret' in one code path.
Signed-off-by: Chris Peterson <cpeterso@cpeterso.com>
---
--- linux-2.6.25-rc1-git7-before/drivers/char/synclink_gt.c 2008-05-10 11:43:19.000000000 -0700
+++ linux-2.6.25-rc1-git7-after/drivers/char/synclink_gt.c 2008-05-10 11:51:22.000000000 -0700
@@ -927,6 +927,8 @@ static int put_char(struct tty_struct *t
if (!info->tx_active && (info->tx_count < info->max_frame_size)) {
info->tx_buf[info->tx_count++] = ch;
ret = 1;
+ } else {
+ ret = 0;
}
spin_unlock_irqrestore(&info->lock,flags);
return ret;
--
| Linus Torvalds | Linux 2.6.27-rc8 |
| Greg KH | [GIT PATCH] driver core patches against 2.6.24 |
| Linus Torvalds | Linux 2.6.27 |
| Rafael J. Wysocki | [Bug #10714] powerpc: Badness seen on 2.6.26-rc2 with lockdep enabled |
git: | |
| Peter Stahlir | Git as a filesystem |
| skimo | [PATCH 02/15] git-config: add --remote option for reading config from remote repo |
| Aaron Bentley | Re: VCS comparison table |
| Carlos Rica | Re: If you would write git from scratch now, what would you change? |
| Pavel Machek | Re: [PATCH] [Request for inclusion] Filesystem in Userspace |
| Arjan van de Ven | Re: GFS, what's remaining |
| Badari Pulavarty | Bufferheads & page-cache reference |
| Suparna Bhattacharya | Reviewing ext3 improvement patches (delalloc, mballoc, extents) |
| Richard Stallman | Real men don't attack straw men |
| Kevin | uvm_mapent_alloc: out of static map entries on 4.3 i386 |
| Brandon Lee | DELL PERC 5iR slow performance |
| Todd Pytel | IDE or SCSI virtual disks for VMWare image? |
| usb mic not detected | 3 hours ago | Applications and Utilities |
| Problem in Inserting a module | 4 hours ago | Linux kernel |
| Treason Uncloaked | 9 hours ago | Linux kernel |
| Shared swap partition | 20 hours ago | Linux general |
| high memory | 2 days ago | Linux kernel |
| semaphore access speed | 2 days ago | Applications and Utilities |
| the kernel how to power off the machine | 2 days ago | Linux kernel |
| Easter Eggs in windows XP | 2 days ago | Windows |
| Root password | 3 days ago | Linux general |
| Where/when DNOTIFY is used? | 3 days ago | Linux kernel |
