On Fri, 2 May 2008 12:27:46 -0600 Hi, I like the concept of the patch; however... BUG() is a tad on the rude side... how about WARN_ON(1) ? --

On Thu, 1 May 2008 21:54:27 -0500 Hi, can we name this file something with "quirks" in it (dmi_quirks.c or so)? At least I tend to look for files named like that when searching for places that do specific hardware/machine based workarounds... Greetings, Arjan van de Ven --

git17 on vmware - modprobe acpi-cpufreq gives the warning below. that also didn`t happen with earlier kernels - so maybe it`s a regression, too. May 2 01:40:21 opensuse103 kernel: ACPI: ACPI0007:00 is registered as cooling_device0 May 2 01:40:21 opensuse103 kernel: ACPI: Processor [CPU0] (supports 8 throttling states) May 2 01:40:24 opensuse103 kernel: sysdev: class cpu: driver (c037d1c0) has already been registered to a class, something is wrong, but will forge on! May 2 01:40:24 opens...

2.6.25-git17-default on vmware - i`m getting oops when modprobe aha1542 (ok, makes no sense in vmware, but i think this is a regression because it never happend before. i did the same test with older kernels) BUG: unable to handle kernel NULL pointer dereference at 00000004 IP: [<d0820766>] :scsi_mod:scsi_destroy_command_freelist+0xd/0x4f *pde = 00000000 Oops: 0000 [#1] SMP Modules linked in: aha1542(+) iptable_filter ip_tables ip6table_filter ip6_tables x_tables ipv6 af_packet microcod...

Where are the segfaults? Do you mean these reports? If so, then this is something other than segfaults. And not quite as critical. Or are things not working for you with this kernel? May 1 16:15:01 kernel: proc_dir_entry 'info' already registered May 1 16:15:01 kernel: Pid: 1099, comm: modprobe Not tainted 2.6.25-git16 #3 May 1 16:15:01 kernel: May 1 16:15:01 kernel: Call Trace: May 1 16:15:01 kernel: [<ffffffff81118269>] idr_get_new+0xb/0x28 May 1 16:15:01 kernel: [<fff...

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- arch/ppc/kernel/ppc-stub.c | 53 ++++++++++++++++++++------------------------ 1 files changed, 24 insertions(+), 29 deletions(-) diff --git a/arch/ppc/kernel/ppc-stub.c b/arch/ppc/kernel/ppc-stub.c index 5f9ee7b..2379f70 100644 --- a/arch/ppc/kernel/ppc-stub.c +++ b/arch/ppc/kernel/ppc-stub.c @@ -130,9 +130,6 @@ static int kgdb_started; static u_int fault_jmp_buf[100]; static int kdebug; - -static const char hexchars[...

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- arch/mips/kernel/gdb-stub.c | 56 +++++++++++++++--------------------------- 1 files changed, 20 insertions(+), 36 deletions(-) diff --git a/arch/mips/kernel/gdb-stub.c b/arch/mips/kernel/gdb-stub.c index 25f4eab..fe81aa4 100644 --- a/arch/mips/kernel/gdb-stub.c +++ b/arch/mips/kernel/gdb-stub.c @@ -164,7 +164,6 @@ extern void adel(void); static void getpacket(char *buffer); static void putpacket(char *buffer); static in...

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- arch/frv/kernel/gdb-stub.c | 163 ++++++++++++++++++++------------------------ 1 files changed, 73 insertions(+), 90 deletions(-) diff --git a/arch/frv/kernel/gdb-stub.c b/arch/frv/kernel/gdb-stub.c index 48a0393..5a369d7 100644 --- a/arch/frv/kernel/gdb-stub.c +++ b/arch/frv/kernel/gdb-stub.c @@ -182,8 +182,6 @@ extern volatile u32 __attribute__((section(".bss"))) gdbstub_trace_through_excep static char input_buffer[BUFMAX];...

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- arch/cris/arch-v10/kernel/kgdb.c | 103 +++++++++++--------------------------- arch/cris/arch-v32/kernel/kgdb.c | 91 +++++++++------------------------ 2 files changed, 54 insertions(+), 140 deletions(-) diff --git a/arch/cris/arch-v10/kernel/kgdb.c b/arch/cris/arch-v10/kernel/kgdb.c index a3ca551..a40581f 100644 --- a/arch/cris/arch-v10/kernel/kgdb.c +++ b/arch/cris/arch-v10/kernel/kgdb.c @@ -278,17 +278,6 @@ void putDebugC...

Everyone rolls their own version around the tree, centralize in lib/hexdump.c Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- include/linux/kernel.h | 6 +++++- lib/hexdump.c | 25 +++++++++++++++++++++++-- 2 files changed, 28 insertions(+), 3 deletions(-) diff --git a/include/linux/kernel.h b/include/linux/kernel.h index 4d46e29..20cae9a 100644 --- a/include/linux/kernel.h +++ b/include/linux/kernel.h @@ -276,7 +276,11 @@ extern void print_hex_dump(const c...

From: "John W. Linville" <linville@tuxdriver.com> Pulled and pushed back out to net-2.6, thanks! --

The file in drivers/rtc/rtc-ds1551.c uses "int" for flags. This can cause hard to find bugs on some architectures. This patch converts the flags to use "long" instead. This bug was discovered by doing an allyesconfig make on the -rt kernel where checks are done to ensure all flags are of size sizeof(long). Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- drivers/rtc/rtc-ds1511.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-compile.git/drivers/rtc/r...

A file in the net/mac80211 directory uses "int" for flags. This can cause hard to find bugs on some architectures. This patch converts the flags to use "long" instead. This bug was discovered by doing an allyesconfig make on the -rt kernel where checks are done to ensure all flags are of size sizeof(long). Signed-off-by: Steven Rostedt <srostedt@redhat.com> --- net/mac80211/rc80211_pid_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-compile.git/net...

According to https://bugzilla.redhat.com/show_bug.cgi?id=435550 the TI TSB43AB22A on an ASUSTeK M2NPV-VM motherboard does not work in dual-buffer mode with dvgrab, but does so in packet-per-buffer mode. Other TSB43AB22 or TSB43AB22A cards do not exhibit this problem. The least-cost "fix" for now is to force TSB43AB22A on ASUS boards into packet-per-buffer mode in isochronous reception. Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> --- (subject to retesting by the reporter) ...

diff --git a/Makefile b/Makefile index 39516bf..675d37c 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 25 -EXTRAVERSION = +EXTRAVERSION = .1 NAME = Funky Weasel is Jiggy wit it # *DOCUMENTATION* diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c index 8c71daf..9fee37e 100644 --- a/arch/alpha/kernel/osf_sys.c +++ b/arch/alpha/kernel/osf_sys.c @@ -75,6 +75,7 @@ osf_set_program_attributes(unsigned long text_start, unsigned ...

diff --git a/Makefile b/Makefile index 822d1ba..f619bbc 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 24 -EXTRAVERSION = .5 +EXTRAVERSION = .6 NAME = Err Metey! A Heury Beelge-a Ret! # *DOCUMENTATION* diff --git a/arch/x86/kernel/io_apic_32.c b/arch/x86/kernel/io_apic_32.c index 232fdeb..9994c52 100644 --- a/arch/x86/kernel/io_apic_32.c +++ b/arch/x86/kernel/io_apic_32.c @@ -2478,6 +2478,7 @@ void destroy_irq(unsigned int irq) dynamic_i...

We have to set the ISAPNP register index when setting an IRQ via the sysfs interface. We already do it for IO, MEM, and DMA resources; I just missed the IRQ one. This needs to be in 2.6.26. Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com> Index: work10/drivers/pnp/interface.c =================================================================== --- work10.orig/drivers/pnp/interface.c 2008-05-01 15:26:28.000000000 -0600 +++ work10/drivers/pnp/interface.c 2008-05-01 15:26:39.000000000 -0...

We had checks like that in mainline aswell that caught a lot of errors like this one. Probably got lost in one of the gazillions of spinlock rewrites.. --

Me, me, take me back! commit ee3ce191e8eaa4cc15c51a28b34143b36404c4f5 Author: Alexey Dobriyan <adobriyan@gmail.com> Date: Sat Nov 25 11:09:36 2006 -0800 [PATCH] Enforce "unsigned long flags;" when spinlocking Make it break or warn if you pass to spin_lock_irqsave() and friends something different from "unsigned long flags;". Suprisingly large amount of these was caught by recent commit c53421b18f205c5f97c604ae55c6a921f034b0f6 and others. Idea is ...

On Thu, 1 May 2008 17:50:38 -0400 (EDT) ooh, I'd forgotten about typecheck. y:/usr/src/linux-2.6.25> grep -rl 'unsigned long flags' . | wc -l 2311 eargh. I agree with me. --

On Thu, 01 May 2008 14:26:00 -0700 I think a warning is good enough here. There are all sorts of warnings if, which ignored, will crash your box. And there is only one type which we use to hold processor flags and that is unsigned long. So a plain old #define must_be_ulong(p) do { if (&p == (unsigned long *)0) ; } while (0) (or whatever) should suffice. --

I think we ultimately want something informative if it's possible. That's what I want. Daniel --

One comment near BUILD_BUG_ON is enough (and everything we can do). --

[ I added Ingo since I think he created the check ] It's not messy at all, it's actually quite elegant. I can pull it out of the -rt tree, or perhaps Ingo can quickly whip one up as well. Ingo, you want me to pull it out? -- Steve --

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- arch/cris/arch-v10/kernel/kgdb.c | 103 +++++++++++--------------------------- arch/cris/arch-v32/kernel/kgdb.c | 91 +++++++++------------------------ 2 files changed, 54 insertions(+), 140 deletions(-) diff --git a/arch/cris/arch-v10/kernel/kgdb.c b/arch/cris/arch-v10/kernel/kgdb.c index a3ca551..a40581f 100644 --- a/arch/cris/arch-v10/kernel/kgdb.c +++ b/arch/cris/arch-v10/kernel/kgdb.c @@ -278,17 +278,6 @@ void putDebugC...