[PATCH] fix irq flags in saa7134

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: LKML <linux-kernel@...>
Cc: <akpm@...>, Gerd Knorr <kraxel@...>
Date: Thursday, May 1, 2008 - 6:49 pm

Some files in the drivers/media/video/saa7134 directory uses "int" for flags.
This can cause hard to find bugs on some architectures. This patch converts the
flags to use "long" instead.

This bug was discovered by doing an allyesconfig make on the -rt kernel
where checks are done to ensure all flags are of size sizeof(long).

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
 drivers/media/video/saa7134/saa7134-video.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-compile.git/drivers/media/video/saa7134/saa7134-video.c
===================================================================
--- linux-compile.git.orig/drivers/media/video/saa7134/saa7134-video.c	2008-05-01 16:58:39.000000000 -0400
+++ linux-compile.git/drivers/media/video/saa7134/saa7134-video.c	2008-05-01 18:37:57.000000000 -0400
@@ -1634,7 +1634,7 @@ static int saa7134_s_fmt_overlay(struct
 	struct saa7134_fh *fh = priv;
 	struct saa7134_dev *dev = fh->dev;
 	int err;
-	unsigned int flags;
+	unsigned long flags;

 	if (saa7134_no_overlay > 0) {
 		printk(KERN_ERR "V4L2_BUF_TYPE_VIDEO_OVERLAY: no_overlay\n");

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] fix irq flags in saa7134, Steven Rostedt, (Thu May 1, 6:49 pm)