Re: [PATCH] fix flags length in net 9p

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Steven Rostedt <rostedt@...>

Cc: <adobriyan@...>, <linux-kernel@...>, <lucho@...>, <ericvh@...>, <mingo@...>

Subject: Re: [PATCH] fix flags length in net 9p

Date: Thursday, May 1, 2008 - 6:15 pm

On Thu, 1 May 2008 17:50:38 -0400 (EDT)
Steven Rostedt <rostedt@goodmis.org> wrote:

quoted text> 
> 
> 
> > +		typecheck(unsigned long, flags);

ooh, I'd forgotten about typecheck.

Just use typecheck.  The BUILD_BUG_ON is overkill.

quoted text> We can simply have all users of flags use the new irqflags_t type, and
> just do a one time big patch (grant you, that would break all pending
> patches before that). But we can also write up a script that can convert
> patches as well.

y:/usr/src/linux-2.6.25> grep -rl 'unsigned long flags' . | wc -l
2311

eargh.  I agree with me.
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] fix flags length in net 9p , Steven Rostedt, (Thu May 1, 5:08 pm)

Re: [PATCH] fix flags length in net 9p, Enrico Weigelt, (Fri May 2, 7:39 am)

Re: [PATCH] fix flags length in net 9p, Christoph Hellwig, (Thu May 1, 6:03 pm)

Re: [PATCH] fix flags length in net 9p, Andrew Morton, (Thu May 1, 5:19 pm)

Re: [PATCH] fix flags length in net 9p, Alexey Dobriyan, (Thu May 1, 6:29 pm)

Re: [PATCH] fix flags length in net 9p, Steven Rostedt, (Thu May 1, 5:50 pm)

Re: [PATCH] fix flags length in net 9p, Andrew Morton, (Thu May 1, 6:15 pm)

Re: [PATCH] fix flags length in net 9p, Daniel Walker, (Thu May 1, 5:26 pm)

Re: [PATCH] fix flags length in net 9p, Andrew Morton, (Thu May 1, 6:07 pm)

Re: [PATCH] fix flags length in net 9p, Adrian Bunk, (Thu May 1, 5:41 pm)

Re: [PATCH] fix flags length in net 9p, Daniel Walker, (Thu May 1, 6:01 pm)

Re: [PATCH] fix flags length in net 9p, Steven Rostedt, (Thu May 1, 5:38 pm)

Re: [PATCH] fix flags length in net 9p, Alexey Dobriyan, (Thu May 1, 6:32 pm)

Re: [PATCH] fix flags length in net 9p, Steven Rostedt, (Thu May 1, 5:46 pm)

Re: [PATCH] fix flags length in net 9p, Steven Rostedt, (Thu May 1, 5:25 pm)


linux-kernel:
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Nigel Cunningham	Re: [PATCH] Remove process freezer from suspend to RAM pathway
Paul Mundt	Re: 2.6.22-rc4-mm2
Greg Kroah-Hartman	[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
git:

linux-netdev:
Arjan van de Ven	Re: [GIT]: Networking
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Natalie Protasevich	[BUG] New Kernel Bugs
openbsd-misc:

Re: [PATCH] fix flags length in net 9p

Online users