Re: [PATCH] fix flags length in net 9p

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

To: Daniel Walker <dwalker@...>

Cc: Andrew Morton <akpm@...>, Steven Rostedt <rostedt@...>, <linux-kernel@...>, <lucho@...>, <ericvh@...>

Subject: Re: [PATCH] fix flags length in net 9p

Date: Thursday, May 1, 2008 - 6:32 pm

On Thu, May 01, 2008 at 02:26:00PM -0700, Daniel Walker wrote:
quoted text> 
> On Thu, 2008-05-01 at 14:19 -0700, Andrew Morton wrote:
> > On Thu, 1 May 2008 17:08:05 -0400 (EDT)
> > Steven Rostedt <rostedt@goodmis.org> wrote:
> > 
> > > Some files in the net/9p directory uses "int" for flags. This can
> > > cause hard to find bugs on some architectures. This patch converts the
> > > flags to use "long" instead.
> > 
> > gargh.
> > 
> > > This bug was discovered by doing an allyesconfig make on the -rt kernel
> > > where checks are done to ensure all flags are of size sizeof(long).
> > 
> > I was about to suggest that we do something like that...
> > 
> > I wonder how messy it is.  I long ago lost the ability to follow the
> > convolutions in include/linux/spinlock*.h :(  gotta patch?
> 
> The check that's in -rt for this uses BUILD_BUG_ON(), and it's extremely
> cryptic when there is a failure .. Most people will be baffled why the
> build stopped. If a check went into mainline it should at least give you
> some sort of idea what's happening ..

One comment near BUILD_BUG_ON is enough (and everything we can do).

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] fix flags length in net 9p , Steven Rostedt, (Thu May 1, 5:08 pm)

Re: [PATCH] fix flags length in net 9p, Enrico Weigelt, (Fri May 2, 7:39 am)

Re: [PATCH] fix flags length in net 9p, Christoph Hellwig, (Thu May 1, 6:03 pm)

Re: [PATCH] fix flags length in net 9p, Andrew Morton, (Thu May 1, 5:19 pm)

Re: [PATCH] fix flags length in net 9p, Alexey Dobriyan, (Thu May 1, 6:29 pm)

Re: [PATCH] fix flags length in net 9p, Steven Rostedt, (Thu May 1, 5:50 pm)

Re: [PATCH] fix flags length in net 9p, Andrew Morton, (Thu May 1, 6:15 pm)

Re: [PATCH] fix flags length in net 9p, Daniel Walker, (Thu May 1, 5:26 pm)

Re: [PATCH] fix flags length in net 9p, Andrew Morton, (Thu May 1, 6:07 pm)

Re: [PATCH] fix flags length in net 9p, Adrian Bunk, (Thu May 1, 5:41 pm)

Re: [PATCH] fix flags length in net 9p, Daniel Walker, (Thu May 1, 6:01 pm)

Re: [PATCH] fix flags length in net 9p, Steven Rostedt, (Thu May 1, 5:38 pm)

Re: [PATCH] fix flags length in net 9p, Alexey Dobriyan, (Thu May 1, 6:32 pm)

Re: [PATCH] fix flags length in net 9p, Steven Rostedt, (Thu May 1, 5:46 pm)

Re: [PATCH] fix flags length in net 9p, Steven Rostedt, (Thu May 1, 5:25 pm)


linux-kernel:
Tarkan Erimer	Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Greg KH	[GIT PATCH] driver core patches against 2.6.24
clameter	[31/36] Large Blocksize: Core piece
David Woodhouse	Re: [GIT *] Allow request_firmware() to be satisfied from in-kernel, use it in mor...
git:

linux-netdev:

Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
KOSAKI Motohiro	[bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin"
Jarek Poplawski	[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc:

Re: [PATCH] fix flags length in net 9p

Online users