Miles Lane wrote:
quoted text
> Hi Stefan.  Thanks for your patch.  It worked great.

Good, thanks for reporting and testing.

quoted text
> Now I see this in the logs:
> 
> ohci1394: fw-host0: SelfID received outside of bus reset sequence
> IEEE 1394 device has ROM CRC error
> IEEE 1394 device has ROM CRC error
> Program usplash tried to access /dev/mem between 0->8000000.
> ieee1394: Node added: ID:BUS[0-00:1023]  GUID[00d0f54000000173]
> ieee1394: Host added: ID:BUS[0-01:1023]  GUID[00e018000027d06c]
> IEEE 1394 device has ROM CRC error
> IEEE 1394 device has ROM CRC error
> IEEE 1394 device has ROM CRC error
> IEEE 1394 device has ROM CRC error
> IEEE 1394 device has ROM CRC error
> 
> Also, "cat /sys/bus/ieee1394/drivers/raw1394/device_ids" no longer
> causes an error.
> 
> Is it necessary for the code to spit out so many CRC errors for the
> OrangeMicro iBot?

I could look into keeping those messages down to only a single one per 
attempt to fetch the so-called configuration ROM of an added node.

quoted text
> Also, are these errors indicating a significant
> problem with the iBot?

The config ROM is an area in the IEEE 1394 address space of a node which 
contains information about the device functions.  It consists of a 
header, a root directory, and subdirectories.  Each one of those has 
CRCs as one safeguard (among others) against integrity issues with the 
data read from the ROM.

A few devices, especially older ones, got the CRC algorithm wrong. Hence 
we don't reject those devices, we only warn about them as a starting 
point for further diagnosis in case that more than this goes wrong when 
using the device.

(The ROM CRC error warning has been added in 2.6.22.  Before Linux 
2.6.22, the ROM CRC errors were silently accepted.  The new alternative 
firewire drivers also do not warn about ROM CRC errors... yet...)
-- 
Stefan Richter
-=====-==--- -=-= ----=
http://arcgraph.de/sr/
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/