Re: arch/x86/kernel/acpi/realmode/Makefile

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Sam Ravnborg
Date: Thursday, May 1, 2008 - 2:39 am

On Wed, Apr 30, 2008 at 06:05:16PM -0700, Roland McGrath wrote:

We have an additional bug where we always do a link of vmlinux.
Testing the following patch atm:

diff --git a/Makefile b/Makefile
index d3634cd..5cf8258 100644
--- a/Makefile
+++ b/Makefile
@@ -794,7 +794,7 @@ endif # ifdef CONFIG_KALLSYMS
 quiet_cmd_vmlinux-modpost = LD      $@
       cmd_vmlinux-modpost = $(LD) $(LDFLAGS) -r -o $@                          \
 	 $(vmlinux-init) --start-group $(vmlinux-main) --end-group             \
-	 $(filter-out $(vmlinux-init) $(vmlinux-main) $(vmlinux-lds) FORCE ,$^)
+	 $(filter-out $(vmlinux-init) $(vmlinux-main) FORCE ,$^)
 define rule_vmlinux-modpost
 	:
 	+$(call cmd,vmlinux-modpost)
@@ -818,7 +818,9 @@ endif
 ifdef CONFIG_KALLSYMS
 .tmp_vmlinux1: vmlinux.o
 endif
-vmlinux.o: $(vmlinux-lds) $(vmlinux-init) $(vmlinux-main) FORCE
+
+modpost-init := $(filter-out init/built-in.o, $(vmlinux-init))
+vmlinux.o: $(modpost-init) $(vmlinux-main) FORCE
 	$(call if_changed_rule,vmlinux-modpost)
 
 # The actual objects are generated when descending, 
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
arch/x86/kernel/acpi/realmode/Makefile, Roland McGrath, (Wed Apr 30, 6:05 pm)
[PATCH] fix rebuild of wakeup.bin, Sam Ravnborg, (Thu May 1, 2:31 am)
Re: arch/x86/kernel/acpi/realmode/Makefile, Sam Ravnborg, (Thu May 1, 2:39 am)
Re: [PATCH] fix rebuild of wakeup.bin, Rafael J. Wysocki, (Thu May 1, 3:48 am)
Re: [PATCH] fix rebuild of wakeup.bin, Ingo Molnar, (Sat May 3, 11:06 am)
Re: [PATCH] fix rebuild of wakeup.bin, Sam Ravnborg, (Sat May 3, 11:15 am)
Re: [PATCH] fix rebuild of wakeup.bin, Ingo Molnar, (Sat May 3, 12:41 pm)
Re: [PATCH] fix rebuild of wakeup.bin, Sam Ravnborg, (Sun May 4, 12:21 am)