On Tue, Apr 29, 2008 at 05:42:31PM -0400, J. Bruce Fields wrote:The hell it might. Leases are broken, plain and simple. Not to mention anything else, a couple of threads with shared descriptor table will bypass these checks happily. FWIW, that's far from the worst problem in fs/locks.c, and not even the worst one with leases. That, BTW, is a fine demonstration of the reasons why application-specific kernel warts(tm) are bad. Lease support is samba-only turd; so's dnotify, with its lovely problems. And interfaces like that *suck*; they are developed with one application in mind and that leads to "we know how it will be used" mentality. With obvious implications for quality of review they get from their developers... Al, currently crawling through struct file_lock review and extremely annoyed by the amount of turds being found... --
| Alan Cox | Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3 |
| Jan Engelhardt | intel iommu (Re: -mm merge plans for 2.6.23) |
| Adrian Bunk | Re: LSM conversion to static interface |
| Greg Kroah-Hartman | [PATCH 004/196] Chinese: add translation of SubmittingPatches |
git: | |
| Gerrit Renker | [PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side) |
| Jarek Poplawski | [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Andrew Morton | Re: [BUG] New Kernel Bugs |
| Winkler, Tomas | RE: iwlwifi: fix build bug in "iwlwifi: fix LED stall" |
