Re: olpc_battery_trigger_uevent() is unused

Previous thread: [patch] inlining: do not allow gcc below version 4 to optimize inlining by Ingo Molnar on Tuesday, April 29, 2008 - 3:15 pm. (4 messages)

Next thread: BUILD error on latest git , ( some *_attach [drivers/media/video/tuner.ko] undefined! ) by Gabriel C on Tuesday, April 29, 2008 - 4:11 pm. (1 message)
From: Adrian Bunk
Date: Tuesday, April 29, 2008 - 3:29 pm

drivers/power/olpc_battery.c:olpc_battery_trigger_uevent() is unused.

Should it have been used?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--

From: Andres Salomon
Date: Tuesday, April 29, 2008 - 4:01 pm

On Wed, 30 Apr 2008 01:29:51 +0300

It will get used once the olpc power management code makes it
upstream.  The olpc_register_battery_callback stuff that Andrew removed
was related to that.

Remove it now if you like, but I'm hoping to get it in for the 2.6.27
merge window.
--

From: Adrian Bunk
Date: Wednesday, April 30, 2008 - 7:16 pm

I'm not that trigger-happy.  ;-)

I was actually more interested in whether it should have been used
(AKA there would be a bug somewhere).

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--

Previous thread: [patch] inlining: do not allow gcc below version 4 to optimize inlining by Ingo Molnar on Tuesday, April 29, 2008 - 3:15 pm. (4 messages)

Next thread: BUILD error on latest git , ( some *_attach [drivers/media/video/tuner.ko] undefined! ) by Gabriel C on Tuesday, April 29, 2008 - 4:11 pm. (1 message)