Re: [PATCH] [12/18] Add support to allocate hugetlb pages that are larger than MAX_ORDER | KernelTrap

Re: [PATCH] [12/18] Add support to allocate hugetlb pages that are larger than MAX_ORDER

view
thread

!MAILaRCHIVE_VOTE_RePLACE

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Andi Kleen <andi@...>

To: Andrew Hastings <abh@...>

Cc: Andi Kleen <andi@...>, <linux-kernel@...>, <pj@...>, <linux-mm@...>, <nickpiggin@...>

Subject: Re: [PATCH] [12/18] Add support to allocate hugetlb pages that are larger than MAX_ORDER

Date: Wednesday, April 9, 2008 - 1:56 pm

> This looks like an off-by-one error here and in the code below -- it 
quoted text> should be ">= MAX_ORDER" not "> MAX_ORDER".  Cf alloc_pages() in gfp.h:
> 
>         if (unlikely(order >= MAX_ORDER))
>                 return NULL;

True good point. Although it will only matter if some architecture
has MAX_ORDER sized huge pages :) x86-64 definitely hasn't.

I passed this code over to Nick so he'll hopefully incorporate the fix.

-Andi
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] [0/18] GB pages hugetlb support, Andi Kleen, (Sun Mar 16, 9:58 pm)

Re: [PATCH] [0/18] GB pages hugetlb support, Paul Jackson, (Mon Mar 17, 5:26 am)

[PATCH] [18/18] Implement hugepagesz= option for x86-64, Andi Kleen, (Sun Mar 16, 9:58 pm)

Re: [PATCH] [18/18] Implement hugepagesz= option for x86-64, Paul Jackson, (Mon Mar 17, 5:29 am)

Re: [PATCH] [18/18] Implement hugepagesz= option for x86-64, Andi Kleen, (Mon Mar 17, 5:59 am)

Re: [PATCH] [18/18] Implement hugepagesz= option for x86-64, Paul Jackson, (Mon Mar 17, 6:02 am)

[PATCH] [17/18] Add huge pud support to mm/memory.c, Andi Kleen, (Sun Mar 16, 9:58 pm)

[PATCH] [16/18] Add huge pud support to hugetlbfs, Andi Kleen, (Sun Mar 16, 9:58 pm)

[PATCH] [15/18] Add support to x86-64 to allocate and lookup..., Andi Kleen, (Sun Mar 16, 9:58 pm)

[PATCH] [14/18] Clean up hugetlb boot time printk, Andi Kleen, (Sun Mar 16, 9:58 pm)

Re: [PATCH] [14/18] Clean up hugetlb boot time printk, Mel Gorman, (Tue Mar 18, 12:37 pm)

[PATCH] [13/18] Add support to allocate hugepages of differe..., Andi Kleen, (Sun Mar 16, 9:58 pm)

Re: [PATCH] [13/18] Add support to allocate hugepages of dif..., Mel Gorman, (Tue Mar 18, 12:32 pm)

Re: [PATCH] [13/18] Add support to allocate hugepages of dif..., Andi Kleen, (Tue Mar 18, 12:45 pm)

Re: [PATCH] [13/18] Add support to allocate hugepages of dif..., Mel Gorman, (Tue Mar 18, 12:46 pm)

[PATCH] [12/18] Add support to allocate hugetlb pages that a..., Andi Kleen, (Sun Mar 16, 9:58 pm)

Re: [PATCH] [12/18] Add support to allocate hugetlb pages th..., Andrew Hastings, (Wed Apr 9, 12:05 pm)

Re: [PATCH] [12/18] Add support to allocate hugetlb pages th..., Andi Kleen, (Wed Apr 9, 1:56 pm)

Re: [PATCH] [12/18] Add support to allocate hugetlb pages th..., Mel Gorman, (Tue Mar 18, 12:27 pm)

[PATCH] [11/18] Fix alignment bug in bootmem allocator, Andi Kleen, (Sun Mar 16, 9:58 pm)

Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Yinghai Lu, (Sun Mar 16, 10:19 pm)

Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Andi Kleen, (Mon Mar 17, 3:02 am)

Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Yinghai Lu, (Mon Mar 17, 3:17 am)

Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Yinghai Lu, (Mon Mar 17, 3:31 am)

Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Andi Kleen, (Mon Mar 17, 3:41 am)

Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Yinghai Lu, (Mon Mar 17, 3:53 am)

Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Yinghai Lu, (Mon Mar 17, 4:10 am)

Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Andi Kleen, (Mon Mar 17, 4:17 am)

Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Andi Kleen, (Mon Mar 17, 4:56 am)

Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Yinghai Lu, (Mon Mar 17, 2:52 pm)

Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Yinghai Lu, (Mon Mar 17, 5:27 pm)

Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Yinghai Lu, (Mon Mar 17, 10:06 pm)

Re: [PATCH] [11/18] Fix alignment bug in bootmem allocator, Mel Gorman, (Tue Mar 18, 12:18 pm)

[PATCH] [10/18] Factor out new huge page preparation code in..., Andi Kleen, (Sun Mar 16, 9:58 pm)

Re: [PATCH] [10/18] Factor out new huge page preparation cod..., Mel Gorman, (Tue Mar 18, 12:02 pm)

Re: [PATCH] [10/18] Factor out new huge page preparation cod..., Adam Litke, (Mon Mar 17, 4:31 pm)

[PATCH] [9/18] Export prep_compound_page to the hugetlb allo..., Andi Kleen, (Sun Mar 16, 9:58 pm)

[PATCH] [8/18] Add a __alloc_bootmem_node_nopanic, Andi Kleen, (Sun Mar 16, 9:58 pm)

Re: [PATCH] [8/18] Add a __alloc_bootmem_node_nopanic, Mel Gorman, (Tue Mar 18, 11:54 am)

[PATCH] [7/18] Abstract out the NUMA node round robin code i..., Andi Kleen, (Sun Mar 16, 9:58 pm)

Re: [PATCH] [7/18] Abstract out the NUMA node round robin co..., Mel Gorman, (Tue Mar 18, 11:42 am)

Re: [PATCH] [7/18] Abstract out the NUMA node round robin co..., Andi Kleen, (Tue Mar 18, 11:47 am)

Re: [PATCH] [7/18] Abstract out the NUMA node round robin co..., Mel Gorman, (Tue Mar 18, 12:04 pm)

[PATCH] [6/18] Add support to have individual hstates for ea..., Andi Kleen, (Sun Mar 16, 9:58 pm)

Re: [PATCH] [6/18] Add support to have individual hstates fo..., Mel Gorman, (Tue Mar 18, 11:02 am)

Re: [PATCH] [6/18] Add support to have individual hstates fo..., Adam Litke, (Tue Mar 18, 10:10 am)

[PATCH] [5/18] Expand the hugetlbfs sysctls to handle arrays..., Andi Kleen, (Sun Mar 16, 9:58 pm)

Re: [PATCH] [5/18] Expand the hugetlbfs sysctls to handle ar..., Mel Gorman, (Tue Mar 18, 10:34 am)

Re: [PATCH] [5/18] Expand the hugetlbfs sysctls to handle ar..., Andi Kleen, (Tue Mar 18, 12:49 pm)

Re: [PATCH] [5/18] Expand the hugetlbfs sysctls to handle ar..., Mel Gorman, (Tue Mar 18, 1:01 pm)

[PATCH] [4/18] Add basic support for more than one hstate in..., Andi Kleen, (Sun Mar 16, 9:58 pm)

Re: [PATCH] [4/18] Add basic support for more than one hstat..., Mel Gorman, (Tue Mar 18, 10:11 am)

Re: [PATCH] [4/18] Add basic support for more than one hstat..., Paul Jackson, (Mon Mar 17, 4:09 am)

Re: [PATCH] [4/18] Add basic support for more than one hstat..., Andi Kleen, (Mon Mar 17, 4:15 am)

Re: [PATCH] [4/18] Add basic support for more than one hstat..., Adam Litke, (Mon Mar 17, 4:28 pm)

[PATCH] [3/18] Convert /proc output code over to report mult..., Andi Kleen, (Sun Mar 16, 9:58 pm)

Re: [PATCH] [3/18] Convert /proc output code over to report ..., Mel Gorman, (Tue Mar 18, 8:28 am)

[PATCH] [2/18] Add basic support for more than one hstate in..., Andi Kleen, (Sun Mar 16, 9:58 pm)

Re: [PATCH] [2/18] Add basic support for more than one hstat..., KOSAKI Motohiro, (Sun Mar 23, 6:38 am)

Re: [PATCH] [2/18] Add basic support for more than one hstat..., Andi Kleen, (Sun Mar 23, 7:28 am)

Re: [PATCH] [2/18] Add basic support for more than one hstat..., KOSAKI Motohiro, (Sun Mar 23, 7:30 am)

Re: [PATCH] [2/18] Add basic support for more than one hstat..., Mel Gorman, (Tue Mar 18, 8:23 am)

Re: [PATCH] [2/18] Add basic support for more than one hstat..., Adam Litke, (Mon Mar 17, 4:22 pm)

Re: [PATCH] [2/18] Add basic support for more than one hstat..., Andi Kleen, (Mon Mar 17, 4:44 pm)

[PATCH] [1/18] Convert hugeltlb.c over to pass global state ..., Andi Kleen, (Sun Mar 16, 9:58 pm)

Re: [PATCH] [1/18] Convert hugeltlb.c over to pass global st..., Mel Gorman, (Tue Mar 18, 8:05 am)

Re: [PATCH] [1/18] Convert hugeltlb.c over to pass global st..., Adam Litke, (Mon Mar 17, 4:15 pm)

Re: [PATCH] [0/18] GB pages hugetlb support, Paul Jackson, (Mon Mar 17, 1:35 am)

Re: [PATCH] [0/18] GB pages hugetlb support, Andi Kleen, (Mon Mar 17, 2:58 am)

Re: [PATCH] [0/18] GB pages hugetlb support, Paul Jackson, (Sun Mar 16, 11:11 pm)

Re: [PATCH] [0/18] GB pages hugetlb support, Andi Kleen, (Mon Mar 17, 3:00 am)

Re: [PATCH] [0/18] GB pages hugetlb support, Paul Jackson, (Mon Mar 17, 3:00 am)

Re: [PATCH] [0/18] GB pages hugetlb support, Andi Kleen, (Mon Mar 17, 3:29 am)

Re: [PATCH] [0/18] GB pages hugetlb support, Adam Litke, (Mon Mar 17, 11:05 am)

Re: [PATCH] [0/18] GB pages hugetlb support, Andi Kleen, (Mon Mar 17, 11:33 am)

Re: [PATCH] [0/18] GB pages hugetlb support, Adam Litke, (Mon Mar 17, 11:59 am)

Navigation

Popular discussions


linux-kernel:
Dave Hansen	[RFC][PATCH 0/4] kernel-based checkpoint restart
Greg KH	[GIT PATCH] driver core patches against 2.6.24
Bart Van Assche	Integration of SCST in the mainstream Linux kernel
Eric Paris	[RFC 0/5] [TALPA] Intro to a linux interface for on access scanning
git:

linux-netdev:
David Miller	Re: [GIT]: Networking
Natalie Protasevich	[BUG] New Kernel Bugs
Gerrit Renker	[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
Jarek Poplawski	Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
openbsd-misc:

Colocation donated by:

Who's online

There are currently 14 users and 1166 guests online.

Online users

Syndicate