login
Header Space

 
 

Re: [PATCH] scsi: fix sense_slab/bio swapping livelock

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Hugh Dickins <hugh@...>
Cc: James Bottomley <James.Bottomley@...>, Linus Torvalds <torvalds@...>, Andrew Morton <akpm@...>, FUJITA Tomonori <fujita.tomonori@...>, Jens Axboe <jens.axboe@...>, Pekka Enberg <penberg@...>, Peter Zijlstra <a.p.zijlstra@...>, Rafael J. Wysocki <rjw@...>, <linux-kernel@...>
Date: Tuesday, April 8, 2008 - 4:43 pm

On Mon, 7 Apr 2008, Hugh Dickins wrote:


Looks like that one of the issues here is that swap_writepage() 
does not perform enough reclaim? If it would free more pages then 
__scsi_get_command would still have pages to allocate and not drain
the reserves.


Mempool_alloc()s use of the gfp_mask here suggests that it can potentially 
drain all reserves and exhaust all available "slots" (partial slabs). Thus 
it may regularly force any other user of the slab to hit the slow path 
and potentially trigger reclaim. Could be a bit unfair.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] scsi: fix sense_slab/bio swapping livelock, Hugh Dickins, (Sun Apr 6, 6:56 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Christoph Lameter, (Mon Apr 7, 1:26 am)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Hugh Dickins, (Mon Apr 7, 3:40 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Christoph Lameter, (Tue Apr 8, 4:43 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Peter Zijlstra, (Mon Apr 7, 3:55 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Hugh Dickins, (Mon Apr 7, 4:31 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Pekka Enberg, (Mon Apr 7, 5:00 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Pekka Enberg, (Mon Apr 7, 5:05 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Hugh Dickins, (Mon Apr 7, 5:30 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Pekka Enberg, (Mon Apr 7, 5:36 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Linus Torvalds, (Mon Apr 7, 5:15 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Pekka Enberg, (Mon Apr 7, 5:34 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Pekka Enberg, (Mon Apr 7, 5:39 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Pekka J Enberg, (Mon Apr 7, 6:05 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Linus Torvalds, (Mon Apr 7, 6:17 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Pekka J Enberg, (Tue Apr 8, 4:42 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Christoph Lameter, (Tue Apr 8, 4:45 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Pekka Enberg, (Tue Apr 8, 5:11 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Peter Zijlstra, (Tue Apr 8, 5:40 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Pekka Enberg, (Tue Apr 8, 4:44 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Pekka Enberg, (Mon Apr 7, 6:42 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Peter Zijlstra, (Mon Apr 7, 4:47 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, FUJITA Tomonori, (Sun Apr 6, 10:48 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Hugh Dickins, (Mon Apr 7, 2:07 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, FUJITA Tomonori, (Tue Apr 8, 10:04 am)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, James Bottomley, (Sun Apr 6, 7:35 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Hugh Dickins, (Sun Apr 6, 9:01 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Hugh Dickins, (Mon Apr 7, 1:51 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, James Bottomley, (Mon Apr 7, 2:04 pm)
Re: [PATCH] scsi: fix sense_slab/bio swapping livelock, Hugh Dickins, (Mon Apr 7, 2:26 pm)
speck-geostationary