login
Header Space

 
 

Re: [PATCH 6/6] Clocklib: use correct name for 3,6MHz clock

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Dmitry <dbaryshkov@...>
Cc: Andrew Morton <akpm@...>, <linux-kernel@...>, <haavard.skinnemoen@...>, <lethal@...>, <philipp.zabel@...>, <pavel@...>, <tony@...>, <paul@...>
Date: Tuesday, April 8, 2008 - 4:07 pm

On Tue, Apr 08, 2008 at 11:58:11PM +0400, Dmitry wrote:

You missed the fundamental issue about the clock API - the _name_ is
not the clock name defined by the host.  It's the _device_ clock name.

So, you shouldn't be using the SA1111 clock name for the tc6393xb driver.
You should be using its own name.  The platform specific bit of the clock
API is then supposed to return you the struct clk corresponding with
that input, by using the platform knowledge that it's connected to GPIO27
or whatever.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/6] Clocklib: generic clocks framework, Dmitry Baryshkov, (Thu Apr 3, 9:21 am)
[PATCH 6/6] Clocklib: use correct name for 3,6MHz clock, Dmitry Baryshkov, (Thu Apr 3, 9:24 am)
Re: [PATCH 6/6] Clocklib: use correct name for 3,6MHz clock, Russell King, (Tue Apr 8, 4:07 pm)
Re: [PATCH 6/6] Clocklib: use correct name for 3,6MHz clock, Dmitry Baryshkov, (Fri Apr 11, 6:25 am)
[PATCH 5/6] Clocklib: Use correct clock for IrDA on pxa, Dmitry Baryshkov, (Thu Apr 3, 9:24 am)
[PATCH 4/6] Clocklib: support ARM pxa sub-arch., Dmitry Baryshkov, (Thu Apr 3, 9:23 am)
[PATCH 3/6] Clocklib: support sa1100 sub-arch., Dmitry Baryshkov, (Thu Apr 3, 9:23 am)
[PATCH 2/6] Clocklib: debugfs support, Dmitry Baryshkov, (Thu Apr 3, 9:23 am)
Re: [PATCH 2/6] Clocklib: debugfs support, Andrew Morton, (Mon Apr 7, 6:59 pm)
Re: [PATCH 2/6] Clocklib: debugfs support, Greg KH, (Mon Apr 7, 9:04 pm)
speck-geostationary