Rusty Russell wrote:In general the code looks good. The only thing I could not convince myself in is whether having generic ring buffer makes sense or not. At least the TUN driver would be more efficient if it had its own simple ring implementation. Less indirection, fewer callbacks, fewer if()s, etc. TUN already has the file descriptor and having two additional fds for rx and tx ring is a waste (think of a VPN server that has to have a bunch of TUN fds). Also as I mentioned before Jamal and I wanted to expose some of the SKB fields through TUN device. With the rx/tx rings the natural way of doing that would be the ring descriptor itself. It can of course be done the same way we copy proto info (PI) and GSO stuff before the packet but that means more copy_to_user() calls and yet more checks. So. What am I missing ? Why do we need generic ring for the TUN ? I looked at the lguest code a bit and it seems that we need a bunch of network specific code anyway. The cool thing is that you can now mmap the rings into the guest directly but the same thing can be done with TUN specific rings. Max --
| Ryan Hope | reiser4 for 2.6.27-rc1 |
| Bart Van Assche | Integration of SCST in the mainstream Linux kernel |
| Pierre Ossman | [RFC][PATCH] cpuidle: avoid singing capacitors |
| Rafael J. Wysocki | 2.6.26-rc9-git12: Reported regressions from 2.6.25 |
git: | |
| Marius Storm-Olsen | Stats in Git |
| Jakub Narebski | [PATCH] gitweb: Use File::Find::find in git_get_projects_list |
| Johannes Schindelin | [PATCH 01/15] Mark strings for translation. |
| Linus Torvalds | Re: git and larger trees, not so fast? |
| Richard Stallman | Real men don't attack straw men |
| Steven Surdock | Problems with second ipsec(ctl) tunnel |
| GVG GVG | ssh_exchange_identification: Connection closed by remote host |
| Bertram Scharpf | First install: Grub doesn't find partitions |
| Jim Winstead Jr. | Re: Root Disk/Book Disk Compatibility |
| Stephen Pierce | SLS |
| Les Andrzejewski | X386/WD90C31/SUMSUNG SYNC MASTER 4 |
| Sander van Malssen | uemacs |
