login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
April
»
8
Re: [PATCH,RFC] Add call_rcu_sched()
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Andrew Morton
Subject:
Re: [PATCH,RFC] Add call_rcu_sched()
Date: Tuesday, April 8, 2008 - 2:07 am
On Tue, 8 Apr 2008 14:26:37 +0530 Gautham R Shenoy <ego@in.ibm.com> wrote:
quoted text
> On Tue, Apr 08, 2008 at 01:39:36AM -0700, Andrew Morton wrote: > > On Tue, 8 Apr 2008 13:40:48 +0530 Gautham R Shenoy <ego@in.ibm.com> wrote: > > > > > > > + rdp = RCU_DATA_CPU(cpu); > > > <-- here ------\ > > > > > + spin_lock_irqsave(&rdp->lock, flags); | > > > > > + | > > > > > + /* | > > > > > + * We are running on this CPU irq-disabled, so no | > > > > > + * CPU can go offline until we re-enable irqs. | > > > > | > > > > but, but, but. The cpu at `cpu' could have gone offline just before we | > > > > disabled local interrupts. | > > > | > > > In that case the CPU_DEAD callback should have migrated the rcu-lists to | > > > a cpu which is online. | > > | > > But local variable rdp might be pointing at the now-offlined CPU's data? -------/ > > Right. But then rdp wouldn't contain anything useful at this point. > So, we may only end up taking the rdp->lock, observe that there's nothing to do, > and move on. > > Is there something else that I am missing?
erm, I guess that'll work OK. There were intentions to release the per-cpu memory during unplug, but nobody has threatened to do that for a while. --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH,RFC] Add call_rcu_sched()
, Paul E. McKenney
, (Fri Mar 21, 7:36 am)
[PATCH,RFC] Add call_rcu_sched()
, Paul E. McKenney
, (Fri Mar 21, 3:40 pm)
Re: [PATCH,RFC] Add call_rcu_sched()
, Mathieu Desnoyers
, (Sun Mar 23, 10:06 pm)
Re: [PATCH,RFC] Add call_rcu_sched()
, Paul E. McKenney
, (Sun Mar 23, 10:46 pm)
Re: [PATCH,RFC] Add call_rcu_sched()
, Mathieu Desnoyers
, (Mon Mar 24, 6:59 am)
Re: [PATCH,RFC] Initialize call_rcu_sched sooner
, Mathieu Desnoyers
, (Tue Mar 25, 5:53 am)
Re: [PATCH,RFC] Initialize call_rcu_sched sooner
, Paul E. McKenney
, (Tue Mar 25, 11:49 am)
Re: [PATCH,RFC] Add call_rcu_sched()
, Paul E. McKenney
, (Sun Apr 6, 2:37 pm)
Re: [PATCH,RFC] Add call_rcu_sched()
, Andrew Morton
, (Tue Apr 8, 12:34 am)
Re: [PATCH,RFC] Add call_rcu_sched()
, Gautham R Shenoy
, (Tue Apr 8, 1:10 am)
Re: [PATCH,RFC] Add call_rcu_sched()
, Andrew Morton
, (Tue Apr 8, 1:39 am)
Re: [PATCH,RFC] Add call_rcu_sched()
, Gautham R Shenoy
, (Tue Apr 8, 1:56 am)
Re: [PATCH,RFC] Add call_rcu_sched()
, Andrew Morton
, (Tue Apr 8, 2:07 am)
Re: [PATCH,RFC] Add call_rcu_sched()
, Paul E. McKenney
, (Tue Apr 8, 9:59 am)
Re: [PATCH,RFC] Add call_rcu_sched()
, Paul E. McKenney
, (Tue Apr 8, 10:17 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Michael Trimarchi
Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch
Miklos Szeredi
[patch 14/15] vfs: more path_permission() conversions
Serge E. Hallyn
Re: [RFC v5][PATCH 7/8] Infrastructure for shared objects
Bernd Schmidt
Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3
Takashi Iwai
[PATCH 2/2] input: Add LED support to Synaptics device
git
:
Junio C Hamano
Re: mingw, windows, crlf/lf, and git
Eyvind Bernhardsen
Re: Where has "git ls-remote" reference pattern matching gone?
Shawn O. Pearce
Re: Switching from CVS to GIT
Todd Zullinger
Re: [PATCH 2/2] send-email: rfc2047-quote subject lines with non-ascii characters
Santi Béjar
Re: How to use git-fmt-merge-msg?
linux-netdev
:
Ramkrishna Vepa
[net-2.6 PATCH 1/10] Neterion: New driver: Driver help file
Mark Anthony
invitation / inquiry
Ingo Molnar
Re: [PATCH 08/16] dma-debug: add core checking functions
David Miller
Re: [PATCH 1/3] f_phonet: dev_kfree_skb instead of dev_kfree_skb_any in TX callback
Sascha Hauer
[PATCH 03/12] fec: do not typedef struct types
git-commits-head
:
Linux Kernel Mailing List
amba: struct device - replace bus_id with dev_name(), dev_set_name()
Linux Kernel Mailing List
MIPS: Yosemite: Convert SMP startup lock to arch spinlock.
Linux Kernel Mailing List
ARM: S5PC100: IRQ and timer
Linux Kernel Mailing List
davinci: edma: clear interrupt status for interrupt enabled channels only
Linux Kernel Mailing List
x86, mm, kprobes: fault.c, simplify notify_page_fault()
openbsd-misc
:
Daniel A. Ramaley
Re: [semi-OT] Can anyone recommend an OpenBSD-compatible colour laser printer?
Matthias Kilian
Re: can't get vesa @ 1280x800 or nv
Tobias Ulmer
Re: Problem after upgrade 4.5 to 4.6: ERR M
Philip Guenther
Re: SIGCHLD and libpthread.so
J.C. Roberts
Re: [semi-OT] Can anyone recommend an OpenBSD-compatible colour laser printer?
Colocation donated by:
Syndicate