login
Header Space

 
 

Re: [patch v2] doc: DMA-mapping.txt has undeclared variables [Bug 10397]

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <linux-pci@...>
Cc: Matti Linnanvuori <mattilinnanvuori@...>, Grant Grundler <grundler@...>, <gregkh@...>, <linux-kernel@...>
Date: Monday, April 7, 2008 - 12:05 pm

On Monday, April 07, 2008 9:01 am Matti Linnanvuori wrote:

I think Grant's comment still stands, "fix undeclared variables" isn't an 
accurate description of what you're doing here...

That said, the patch itself looks fine to me, if a bit pedantic.  The compiler 
will catch any mismatched arguments in this case, and the rest of the 
documentation is pretty clear that these routines take struct pci_dev not 
struct device, so I'd be inclined to just leave it the way it is to avoid 
churn.

Jesse
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch v2] doc: DMA-mapping.txt has undeclared variables [Bu..., Matti Linnanvuori, (Mon Apr 7, 12:01 pm)
Re: [patch v2] doc: DMA-mapping.txt has undeclared variables..., Jesse Barnes, (Mon Apr 7, 12:05 pm)
speck-geostationary