login
Header Space

 
 

[PATCH] drivers/ata/sata_via.c - Eliminate "may be used uninitialized" warning

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Jeff Garzik <jgarzik@...>
Cc: linux-ide <linux-ide@...>, LKML <linux-kernel@...>
Date: Sunday, April 6, 2008 - 5:45 pm

Called by svia_init_one with a temporary,
so there's no effective code change.

Signed-off-by: Joe Perches <joe@perches.com>

 drivers/ata/sata_via.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c
index 0d03f44..e01d2b1 100644
--- a/drivers/ata/sata_via.c
+++ b/drivers/ata/sata_via.c
@@ -406,10 +406,9 @@ static int vt6420_prepare_host(struct pci_dev *pdev, struct ata_host **r_host)
 	struct ata_host *host;
 	int rc;
 
-	rc = ata_pci_prepare_sff_host(pdev, ppi, &host);
+	rc = ata_pci_prepare_sff_host(pdev, ppi, r_host);
 	if (rc)
 		return rc;
-	*r_host = host;
 
 	rc = pcim_iomap_regions(pdev, 1 << 5, DRV_NAME);
 	if (rc) {
@@ -417,6 +416,7 @@ static int vt6420_prepare_host(struct pci_dev *pdev, struct ata_host **r_host)
 		return rc;
 	}
 
+	host = *r_host;
 	host->ports[0]->ioaddr.scr_addr = svia_scr_addr(host->iomap[5], 0);
 	host->ports[1]->ioaddr.scr_addr = svia_scr_addr(host->iomap[5], 1);
 


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] drivers/ata/sata_via.c - Eliminate "may be used unin..., Joe Perches, (Sun Apr 6, 5:45 pm)
speck-geostationary