Re: [PATCH] Fix booting pentium+ with dodgy TSC

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Sunday, April 6, 2008 - 4:22 am

* Rusty Russell <rusty@rustcorp.com.au> wrote:


well, while i agree with the patch it could make things worse. In this 
case it can cause code that has been compiled to rely on TSC to 
malfunction. For if sched_clock() was using cpu_has_tsc it could return 
0 all the time, breaking the scheduler without the user having a clear 
idea why it broke. It isnt, and sched_clock() will work fine, but still, 
your "this cant make things worse" statement is not completely correct. 

In any case:

 Acked-by: Ingo Molnar <mingo@elte.hu>

and i've also queued it up into the for-.25 queue of x86.git.

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Fix booting pentium+ with dodgy TSC, Rusty Russell, (Sun Apr 6, 12:23 am)
Re: [PATCH] Fix booting pentium+ with dodgy TSC, Ingo Molnar, (Sun Apr 6, 4:22 am)
Re: [PATCH] Fix booting pentium+ with dodgy TSC, Rusty Russell, (Sun Apr 6, 1:29 pm)
Re: [PATCH] Fix booting pentium+ with dodgy TSC, Pavel Machek, (Fri Apr 11, 8:43 am)