[PATCH] Fix booting pentium+ with dodgy TSC

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Linus Torvalds <torvalds@...>
Cc: Andi Kleen <ak@...>, H. Anvin <hpa@...>, <linux-kernel@...>, Ingo Molnar <mingo@...>, lguest <lguest@...>
Date: Sunday, April 6, 2008 - 3:23 am

Linus please apply.  Almost by definition this patch can't make things worse.

We handle a broken tsc these days, so no need to panic.  We clear the TSC bit
when tsc_init decides it's unreliable (eg. under lguest w/ bad host TSC),
leading to bogus panic.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

diff -r 5e0a39f4d07b arch/x86/kernel/cpu/bugs.c
--- a/arch/x86/kernel/cpu/bugs.c	Sun Apr 06 13:40:39 2008 +1000
+++ b/arch/x86/kernel/cpu/bugs.c	Sun Apr 06 17:14:12 2008 +1000
@@ -143,14 +143,6 @@ static void __init check_config(void)
 #endif
 
 /*
- * If we configured ourselves for a TSC, we'd better have one!
- */
-#ifdef CONFIG_X86_TSC
-	if (!cpu_has_tsc)
-		panic("Kernel compiled for Pentium+, requires TSC feature!");
-#endif
-
-/*
  * If we were told we had a good local APIC, check for buggy Pentia,
  * i.e. all B steppings and the C2 stepping of P54C when using their
  * integrated APIC (see 11AP erratum in "Pentium Processor
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] Fix booting pentium+ with dodgy TSC, Rusty Russell, (Sun Apr 6, 3:23 am)
Re: [PATCH] Fix booting pentium+ with dodgy TSC, Pavel Machek, (Fri Apr 11, 11:43 am)
Re: [PATCH] Fix booting pentium+ with dodgy TSC, Ingo Molnar, (Sun Apr 6, 7:22 am)
Re: [PATCH] Fix booting pentium+ with dodgy TSC, Rusty Russell, (Sun Apr 6, 4:29 pm)