login
Header Space

 
 

Re: [patch] [Bug 10397] DMA-mapping.txt code examples have undeclared variables

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Matti Linnanvuori <mattilinnanvuori@...>
Cc: <linux-kernel@...>, <linux-pci@...>
Date: Sunday, April 6, 2008 - 2:51 am

On Sat, Apr 05, 2008 at 09:34:42PM -0700, Matti Linnanvuori wrote:

Sorry? This changelog entry doesn't make sense to me since this patch
is for documentation and not a compiler error.

If you prefer them declared as C code, please try it this way:

+	struct pci_dev dev*;
+	size_t size;
	dma_addr_t dma_handle;

	cpu_addr = pci_alloc_consistent(dev, size, &dma_handle);

and delete the verbage (plain text) that defines the parameters.

If you are confusing "dev" with "struct device *" and want to change
all the references to "pdev", please do the above *and* write something
like the following in the changelog:
	To avoid confusion with struct device, rename ...

thanks!
grant


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch] [Bug 10397] DMA-mapping.txt code examples have undec..., Matti Linnanvuori, (Sun Apr 6, 12:34 am)
Re: [patch] [Bug 10397] DMA-mapping.txt code examples have u..., Grant Grundler, (Sun Apr 6, 2:51 am)
speck-geostationary