On Fri, 2008-04-04 at 16:58 -0700, David Brownell wrote:Agreed. One issue is that the summary code allocates a buffer that equals the eraseblock size of the underlying MTD device. For larger NAND chips, that may be up to 256KiB. I believe this is within the allowable kmalloc size for most architectures these days, but the summary code is 3 years old and was likely expecting a smaller limit. And there is always the question on whether finding that much contiguous memory will be an issue. I don't see much harm with the actual patch itself, assuming larger kmallocs work as I think they should. It does make me wonder if we have other cases of vmalloc'd buffers being passed to lower drivers using DMA though. josh --
| Greg Kroah-Hartman | [PATCH 002/196] Chinese: rephrase English introduction in HOWTO |
| Tarkan Erimer | Re: Dual-Licensing Linux Kernel with GPL V2 and GPL V3 |
| Roland Dreier | Re: Integration of SCST in the mainstream Linux kernel |
git: | |
| Radu Rendec | htb parallelism on multi-core platforms |
| David Miller | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| David Miller | [GIT]: Networking |
| Gerrit Renker | [PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side) |
