If the cfqc has not specific address, namely cfqc is null,
the cfq_cgroup_init_cfq_data function is called when new device is plugged.
In this time, it needs to relate new cfq_data data with top cfq_cgroup data.
Probably, a running program will be "insmod" in its time.
However, its program is not in root group.
On the supposition that only current interface is usedm,
If using current process, the top cgroup can be calculated by
task_cgroup(current, cfq_subsys_id)->top_cgroup .
Therefore cfq_cgroup data of top cgroup is calculated by
cgroup_to_cfq_cgroup(task_cgroup(current, cfq_subsys_id)->top_cgroup) .
However, It would be bad to use "current" variable in order to
calculate cfq_cgroup data of top cgroup.
Because relationship between "calculating cfq_cgroup data of top cgroup" and
"running(current) task" is weak.
So that you say, root subsystem state maybe keep a reference locally.
For example, create a variable for root subsystem state and
store the pointer when making subsystem state first.
However, I think that it is smart to calculate root group of subsystems
when needing its information.
Does the current code have any problem?
Satoshi UCHIDA.
--
