On Wed, 30 Apr 2008 21:24:27 -0300 I would rather really like to see the assembly output this thing spits; to see if your compiler behaves sanely. (Some distros tend to badly patch their gcc unfortunately and this may break the stack protector feature) --

Finally clean up the odd spacing in these files. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- include/linux/klist.h | 30 ++++---- lib/klist.c | 206 ++++++++++++++++++++----------------------------- 2 files changed, 100 insertions(+), 136 deletions(-) diff --git a/include/linux/klist.h b/include/linux/klist.h index b49385f..06c338e 100644 --- a/include/linux/klist.h +++ b/include/linux/klist.h @@ -34,38 +34,38 @@ struct klist { #define DEFINE_KLIST(_name, _get,...

From: David Brownell <dbrownell@users.sourceforge.net> Make the PCMCIA core stop using class_interface to hide socket attribute registration. This removes the associated section mismatch warnings, and helps get to the point where that mechanism can finally be removed. Simplify that attribute registration by using an attribute_group. This is a net shrink in object size. Signed-off-by: David Brownell <dbrownell@users.sourceforge.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse....

From: Kay Sievers <kay.sievers@vrfy.org> This prevents a few unneeded copies. Signed-off-by: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- lib/kobject.c | 28 ++++++++-------------------- 1 files changed, 8 insertions(+), 20 deletions(-) diff --git a/lib/kobject.c b/lib/kobject.c index fd78740..718e510 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -216,21 +216,12 @@ static int kobject_add_internal(struct kobject *kobj) s...

From: Robert P. J. Day <rpjday@crashcourse.ca> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- fs/debugfs/file.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index fddffe4..159a5ef 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -9,7 +9,7 @@ * 2 as published by the Free Software Foundation. * * debugfs is for people to use inste...

From: Tejun Heo <htejun@gmail.com> Add klist_add_after() and klist_add_before() which puts a new node after and before an existing node, respectively. This is useful for callers which need to keep klist ordered. Note that synchronizing between simultaneous additions for ordering is the caller's responsibility. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- include/linux/klist.h | 2 ++ lib/klist.c | 33 ++++...

From: Ben Hutchings <bhutchings@solarflare.com> sysfs allows attribute files to be truncated, e.g. using ftruncate(), with the expected effect on their inode. For most attributes, this doesn't change the "real" size of the file i.e. how much can be read from it. However, the parameter validation for reading and writing binary attribute files is based on the inode size and not the size specified in the file's bin_attribute, so it can be broken by this. For example, if we try using dd to writ...

Hello, attached is dmesg of proc_dir_entry 'info' already registered; whatever that means. Hopefully this is not that important, just a glitch. Also I know I should'nt talk about 3rd party modules, but with the latest git, it breaks fglrx. Im trying to figure out what was changed or removed so I can at least have some direction as to execute the problem of fixing some broken things. attached is install.log for that situation. [ignore if you are offended] Aside from that I'm not having that irritati...

Hi all, i wonder about the Kernel naming convention in the merge phase before the -rc1 is officially tagged by Linus. Won't it be more precisely to name the current snapshot 2.6.26-merge-git16 instead of 2.6.25-git16? It is not that i would suggest to have a new git tag in this merge phase but only the Makefile should be changed at the beginning of this phase to identify the ongoing work for the 2.6.26: ------ diff --git a/Makefile b/Makefile index d3634cd..b8c85a4 100644 --- a/Makefile...

Just to be clear, the docbook changes shouldn't wait for 2.6.27. There's no need for that. --- ~Randy --

Sure, I'll do that later, hopefully tonight. -- ~Randy --

Otherwise it can only take the values 0/-1 which doesn't seem to have been intended. drivers/input/tablet/wacom.h:108:12: error: dubious one-bit signed bitfield drivers/mmc/host/sdhci.h:190:20: error: dubious one-bit signed bitfield Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> --- drivers/input/tablet/wacom.h | 2 +- drivers/mmc/host/sdhci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/tablet/wacom.h b/drivers/input/tablet/...

drivers/block/xen-blkfront.c:1011:2: warning: returning void-valued expression drivers/isdn/i4l/isdn_net.c:1986:3: warning: returning void-valued expression drivers/rtc/rtc-ds1511.c:648:2: warning: returning void-valued expression drivers/rtc/rtc-stk17ta8.c:416:2: warning: returning void-valued expression drivers/virtio/virtio_pci.c:148:2: warning: returning void-valued expression drivers/virtio/virtio_pci.c:155:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison <harvey.h...

Acked-by: Alan Cox <alan@redhat.com> A --

Well, in an X86_32 allyesconfig, this only trips 32 times...so it's not exactly common. I agree that there is nothing _wrong_ with this, I'll just add Linus and see if we can just call it codingstyle ;) This is just a _trivial_ way to make the sparse output easier for people to use day-to-day for the kernel. There's lots more to do, but this set removes all remaining integer as NUll/ returning void-value/ single bit signed bitfield warnings. Cheers, Harvey --

drivers/video/nvidia/nv_accel.c:304:3: warning: returning void-valued expression drivers/video/nvidia/nv_accel.c:323:3: warning: returning void-valued expression drivers/video/pm3fb.c:543:3: warning: returning void-valued expression drivers/video/neofb.c:1526:4: warning: returning void-valued expression drivers/video/neofb.c:1534:3: warning: returning void-valued expression drivers/video/i810/i810_accel.c:305:3: warning: returning void-valued expression drivers/video/i810/i810_accel.c:331:3: warning: ...

drivers/usb/host/ohci-sm501.c:93:24: warning: Using plain integer as NULL pointer drivers/usb/gadget/amd5536udc.c:3254:9: warning: Using plain integer as NULL pointer drivers/usb/gadget/amd5536udc.c:3267:9: warning: Using plain integer as NULL pointer drivers/usb/gadget/amd5536udc.c:3277:9: warning: Using plain integer as NULL pointer drivers/usb/gadget/amd5536udc.c:3285:9: warning: Using plain integer as NULL pointer drivers/usb/gadget/amd5536udc.c:3293:9: warning: Using plain integer as NULL pointer ...

drivers/scsi/FlashPoint.c:906:9: warning: Using plain integer as NULL pointer drivers/scsi/FlashPoint.c:907:53: warning: Using plain integer as NULL pointer drivers/scsi/FlashPoint.c:922:1: warning: Using plain integer as NULL pointer drivers/scsi/aha152x.c:3585:60: warning: Using plain integer as NULL pointer drivers/scsi/aha152x.c:3845:56: warning: Using plain integer as NULL pointer drivers/scsi/qla1280.c:2814:37: warning: Using plain integer as NULL pointer drivers/scsi/atp870u.c:750:47: warning: ...

Could you please Cc linux-scsi? That way interested parties get to check their drivers. The flashpoint initialiser changes look wrong: {0} is a conventional notation for zero initialise this structure. Sparse should probably be taught to recognise that. --

Yes, but the conventional initialiser doesn't change that (as in zero initialise a static and it ends up in bss anyway). James --

From: Emil Medve <Emilian.Medve@Freescale.com> We provide an ioremap_flags so provide a corresponding devm_ioremap_prot. The slight name difference is at Ben Herrenschmidt request as he plans on changing ioremap_flags to ioremap_prot in the future. Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com> Signed-off-by: Kumar Gala <galak@kernel.crashing.org> --- Renamed at BenH's request to devm_ioremap_prot. arch/powerpc/lib/Makefile | 1 + arch/powerpc/lib/devres.c | ...

Replace TIF_RESTORE_SIGMASK with TS_RESTORE_SIGMASK and define our own set_restore_sigmask() function. This saves the costly SMP-safe set_bit operation, which we do not need for the sigmask flag since TIF_SIGPENDING always has to be set too. Signed-off-by: Roland McGrath <roland@redhat.com> --- arch/ia64/ia32/ia32_signal.c | 2 +- arch/ia64/kernel/signal.c | 15 ++++++++------- include/asm-ia64/thread_info.h | 13 +++++++++++-- 3 files changed, 20 insertions(+), 10 deletions...

The main reason for removing the NexGen support was that the latter had effectively been broken for G-d knows how many years. As a person somehow involved into embedded development, I simply could not resist to trim a few dozen bytes of dead binary code off vmlinux. Besides, the change is trivially revertable (just checked that), and in case that somebody owns a NexGen box and complains, that can be addressed in a matter of minutes. --

Doesn't mean it shipped in anything other than sample or sample-like quantities. -hpa --

Cool. If someone is willing to pick one up and maintain this fairly trivial amount of code we can resurrect it; given that the code had been broken for several releases seem to indicate noone really cares. (Also note that the removal will not prevent the kernel from actually running on these chips; in fact, it might actually make them work.) -hpa --