login
Header Space

 
 

Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Harvey Harrison <harvey.harrison@...>
Cc: Andrew Morton <akpm@...>, James Bottomley <James.Bottomley@...>, LKML <linux-kernel@...>
Date: Wednesday, April 30, 2008 - 7:29 pm

> -				if (tw_dev->srb[request_id] != 0) {

For pointers we should use == NULL or != NULL.

Removing the comparison removes the warning but it doesn't replace it
with any useful typechecking as can be doing with NULL set as (void *)0.

This is thus a backward step.

Alan
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 02/10] scsi: fix integer as NULL pointer warnings, Harvey Harrison, (Wed Apr 30, 6:03 pm)
Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings, Alan Cox, (Wed Apr 30, 7:29 pm)
Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings, James Bottomley, (Wed Apr 30, 6:29 pm)
Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings, Harvey Harrison, (Wed Apr 30, 6:34 pm)
Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings, James Bottomley, (Wed Apr 30, 6:54 pm)
speck-geostationary