login
Login
/
Register
Search
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
April
»
30
Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings
view
thread
!MAILaRCHIVE_VOTE_RePLACE
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From:
Alan Cox <alan@...>
To: Harvey Harrison <harvey.harrison@...>
Cc: Andrew Morton <akpm@...>, James Bottomley <James.Bottomley@...>, LKML <linux-kernel@...>
Subject:
Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings
Date: Wednesday, April 30, 2008 - 7:29 pm
> - if (tw_dev->srb[request_id] != 0) {
quoted text
> + if (tw_dev->srb[request_id]) {
For pointers we should use == NULL or != NULL. Removing the comparison removes the warning but it doesn't replace it with any useful typechecking as can be doing with NULL set as (void *)0. This is thus a backward step. Alan --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[PATCH 02/10] scsi: fix integer as NULL pointer warnings
, Harvey Harrison
, (Wed Apr 30, 6:03 pm)
Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings
, Alan Cox
, (Wed Apr 30, 7:29 pm)
Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings
, James Bottomley
, (Wed Apr 30, 6:29 pm)
RE: [PATCH 02/10] scsi: fix integer as NULL pointer warnings
, Mark Harvey
, (Thu May 1, 5:50 pm)
Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings
, Harvey Harrison
, (Wed Apr 30, 6:34 pm)
Re: [PATCH 02/10] scsi: fix integer as NULL pointer warnings
, James Bottomley
, (Wed Apr 30, 6:54 pm)
Navigation
Create content
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
David Miller
Re: Slow DOWN, please!!!
Greg Kroah-Hartman
[PATCH 001/196] Chinese: Add the known_regression URI to the HOWTO
Bart Van Assche
Integration of SCST in the mainstream Linux kernel
Heiko Carstens
Re: -mm merge plans for 2.6.23 -- sys_fallocate
git
:
linux-netdev
:
Jarek Poplawski
[PATCH] pkt_sched: Destroy gen estimators under rtnl_lock().
Gerrit Renker
[PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side)
David Miller
[GIT]: Networking
Jan Engelhardt
Re: iptables very slow after commit 784544739a25c30637397ace5489eeb6e15d7d49
openbsd-misc
:
Colocation donated by:
Who's online
There are currently
1 user
and
977 guests
online.
Online users
bambooflo
Syndicate