[patch] input: JOYSTICK_XPAD build fix

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Wednesday, April 30, 2008 - 1:03 pm

x86.git testing found the following build failure in -git:

 ERROR: "led_classdev_register" [drivers/input/joystick/xpad.ko] undefined!
 ERROR: "led_classdev_unregister" [drivers/input/joystick/xpad.ko] undefined!

which triggers with the following config:

 http://redhat.com/~mingo/misc/config-Wed_Apr_30_21_43_17_CEST_2008.bad

the reason is dependency on NEW_LEDS that was not spelled out in the
Kconfig entry of JOYSTICK_XPAD.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/input/joystick/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Index: linux/drivers/input/joystick/Kconfig
===================================================================
--- linux.orig/drivers/input/joystick/Kconfig
+++ linux/drivers/input/joystick/Kconfig
@@ -268,6 +268,7 @@ config JOYSTICK_JOYDUMP
 config JOYSTICK_XPAD
 	tristate "X-Box gamepad support"
 	depends on USB_ARCH_HAS_HCD
+	depends on NEW_LEDS
 	select USB
 	help
 	  Say Y here if you want to use the X-Box pad with your computer.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[patch] input: JOYSTICK_XPAD build fix, Ingo Molnar, (Wed Apr 30, 1:03 pm)
Re: [patch] input: JOYSTICK_XPAD build fix, Dmitry Torokhov, (Wed Apr 30, 2:02 pm)
Re: [patch] input: JOYSTICK_XPAD build fix, Ingo Molnar, (Wed Apr 30, 2:13 pm)
Ingo, no more kconfig patches, Adrian Bunk, (Wed Apr 30, 4:01 pm)
Re: Ingo, no more kconfig patches, Ingo Molnar, (Wed Apr 30, 6:17 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Wed Apr 30, 6:37 pm)
Re: Ingo, no more kconfig patches, Ingo Molnar, (Wed Apr 30, 7:06 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Wed Apr 30, 7:12 pm)
Re: Ingo, no more kconfig patches, Ingo Molnar, (Wed Apr 30, 7:52 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Thu May 1, 4:59 am)
Re: Ingo, no more kconfig patches, Ingo Molnar, (Sat May 3, 12:14 pm)
Re: Ingo, no more kconfig patches, Ingo Molnar, (Sat May 3, 12:17 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sat May 3, 1:24 pm)
Re: Ingo, no more kconfig patches, Ingo Molnar, (Sat May 3, 2:03 pm)
Re: Ingo, no more kconfig patches, Krzysztof Halasa, (Sat May 3, 2:17 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sat May 3, 2:24 pm)
Re: Ingo, no more kconfig patches, Sam Ravnborg, (Sat May 3, 2:38 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sat May 3, 2:47 pm)
Re: Ingo, no more kconfig patches, Ingo Molnar, (Sat May 3, 2:52 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sat May 3, 3:03 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sat May 3, 3:07 pm)
Re: Ingo, no more kconfig patches, Krzysztof Halasa, (Sat May 3, 3:13 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sat May 3, 3:29 pm)
Re: Ingo, no more kconfig patches, Thomas Gleixner, (Sat May 3, 4:22 pm)
Re: Ingo, no more kconfig patches, Krzysztof Halasa, (Sat May 3, 4:37 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sat May 3, 5:34 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sat May 3, 5:49 pm)
Re: Ingo, no more kconfig patches, Valdis.Kletnieks, (Sat May 3, 8:54 pm)
Re: Ingo, no more kconfig patches, Sam Ravnborg, (Sun May 4, 12:36 am)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sun May 4, 12:47 am)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sun May 4, 12:49 am)
Re: Ingo, no more kconfig patches, Krzysztof Halasa, (Sun May 4, 5:18 am)