Home » Mailing list archives » linux-kernel » 2008 » April » 30

[patch] input: JOYSTICK_XPAD build fix

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ingo Molnar <mingo@...>
To: Dmitry Torokhov <dmitry.torokhov@...>
Cc: <linux-kernel@...>
Subject: [patch] input: JOYSTICK_XPAD build fix
Date: Wednesday, April 30, 2008 - 4:03 pm

x86.git testing found the following build failure in -git:

 ERROR: "led_classdev_register" [drivers/input/joystick/xpad.ko] undefined!
 ERROR: "led_classdev_unregister" [drivers/input/joystick/xpad.ko] undefined!

which triggers with the following config:

 http://redhat.com/~mingo/misc/config-Wed_Apr_30_21_43_17_CEST_2008.bad

the reason is dependency on NEW_LEDS that was not spelled out in the
Kconfig entry of JOYSTICK_XPAD.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/input/joystick/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Index: linux/drivers/input/joystick/Kconfig
===================================================================
--- linux.orig/drivers/input/joystick/Kconfig
+++ linux/drivers/input/joystick/Kconfig
@@ -268,6 +268,7 @@ config JOYSTICK_JOYDUMP
 config JOYSTICK_XPAD
 	tristate "X-Box gamepad support"
 	depends on USB_ARCH_HAS_HCD
+	depends on NEW_LEDS
 	select USB
 	help
 	  Say Y here if you want to use the X-Box pad with your computer.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[patch] input: JOYSTICK_XPAD build fix, Ingo Molnar, (Wed Apr 30, 4:03 pm)
Re: [patch] input: JOYSTICK_XPAD build fix, Dmitry Torokhov, (Wed Apr 30, 5:02 pm)
Re: [patch] input: JOYSTICK_XPAD build fix, Ingo Molnar, (Wed Apr 30, 5:13 pm)
Ingo, no more kconfig patches, Adrian Bunk, (Wed Apr 30, 7:01 pm)
Re: Ingo, no more kconfig patches, Ingo Molnar, (Wed Apr 30, 10:52 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Thu May 1, 7:59 am)
Re: Ingo, no more kconfig patches, Ingo Molnar, (Sat May 3, 3:14 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sat May 3, 4:24 pm)
Re: Ingo, no more kconfig patches, Krzysztof Halasa, (Sat May 3, 5:17 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sat May 3, 5:47 pm)
Re: Ingo, no more kconfig patches, Krzysztof Halasa, (Sat May 3, 6:13 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sat May 3, 6:29 pm)
Re: Ingo, no more kconfig patches, Krzysztof Halasa, (Sat May 3, 7:37 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sat May 3, 8:49 pm)
Re: Ingo, no more kconfig patches, Krzysztof Halasa, (Sun May 4, 8:18 am)
Re: Ingo, no more kconfig patches, Ingo Molnar, (Sat May 3, 5:03 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sat May 3, 5:24 pm)
Re: Ingo, no more kconfig patches, Thomas Gleixner, (Sat May 3, 7:22 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sat May 3, 8:34 pm)
Re: Ingo, no more kconfig patches, Ingo Molnar, (Sat May 3, 5:52 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sat May 3, 6:03 pm)
Re: Ingo, no more kconfig patches, , (Sat May 3, 11:54 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sun May 4, 3:47 am)
Re: Ingo, no more kconfig patches, Sam Ravnborg, (Sat May 3, 5:38 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sat May 3, 6:07 pm)
Re: Ingo, no more kconfig patches, Sam Ravnborg, (Sun May 4, 3:36 am)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Sun May 4, 3:49 am)
Re: Ingo, no more kconfig patches, Ingo Molnar, (Sat May 3, 3:17 pm)
Re: Ingo, no more kconfig patches, Ingo Molnar, (Wed Apr 30, 9:17 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Wed Apr 30, 9:37 pm)
Re: Ingo, no more kconfig patches, Ingo Molnar, (Wed Apr 30, 10:06 pm)
Re: Ingo, no more kconfig patches, Adrian Bunk, (Wed Apr 30, 10:12 pm)