login
Header Space

 
 

Re: [PATCH 5/7] PPS: serial clients support.

Score:
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Rodolfo Giometti <giometti@...>
Cc: Lennart Sorensen <lsorense@...>, <linux-kernel@...>, Andrew Morton <akpm@...>, David Woodhouse <dwmw2@...>, Dave Jones <davej@...>, Sam Ravnborg <sam@...>, Greg KH <greg@...>, Randy Dunlap <randy.dunlap@...>, Kay Sievers <kay.sievers@...>
Date: Wednesday, April 30, 2008 - 12:28 pm

> if I add a dedicated line discipline to register/unregister the PPS

Keep the two things apart.

uart_handle_dcd_change looks a good basis for the UART layer support for
drivers serial
an LDISC looks right for the top layer

We just need the bits in the middle right. I've added the serial layer
pass through for the set_ldisc() interface so that bit is done. Probably
the main thing we need is to add  tty->ldisc.dcd_change() for reporting
DCD change back to the line discipline. We could queue it as a TTY_ event
but I assume you need it immediately not queued ?


Not every character driver uses drivers/serial or USB. That is fine. What
I care about is that you *could* add PPS support to another serial driver
cleanly, not that it is done immediately. What matters is the interface,
the rest will follow.

Alan
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 5/7] PPS: serial clients support., Rodolfo Giometti, (Thu Apr 10, 12:01 pm)
Re: [PATCH 5/7] PPS: serial clients support., Rodolfo Giometti, (Thu Apr 10, 12:06 pm)
Re: [PATCH 5/7] PPS: serial clients support., Greg KH, (Thu Apr 10, 1:41 pm)
LinuxPPS (RESUBMIT 4): the PPS Linux implementation., Rodolfo Giometti, (Thu Apr 10, 2:22 pm)
[PATCH 1/7] LinuxPPS core support., Rodolfo Giometti, (Thu Apr 10, 2:22 pm)
[PATCH 2/7] PPS: userland header file for PPS API., Rodolfo Giometti, (Thu Apr 10, 2:22 pm)
[PATCH 3/7] PPS: documentation programs and examples., Rodolfo Giometti, (Thu Apr 10, 2:22 pm)
[PATCH 4/7] PPS: LinuxPPS clients support., Rodolfo Giometti, (Thu Apr 10, 2:22 pm)
[PATCH 5/7] PPS: serial clients support., Rodolfo Giometti, (Thu Apr 10, 2:22 pm)
Re: [PATCH 5/7] PPS: serial clients support., Alan Cox, (Thu Apr 10, 4:09 pm)
Re: [PATCH 5/7] PPS: serial clients support., Rodolfo Giometti, (Fri Apr 11, 3:55 am)
Re: [PATCH 5/7] PPS: serial clients support., Alan Cox, (Fri Apr 11, 4:28 am)
Re: [PATCH 5/7] PPS: serial clients support., Lennart Sorensen, (Fri Apr 11, 9:47 am)
Re: [PATCH 5/7] PPS: serial clients support., Alan Cox, (Fri Apr 11, 10:46 am)
Re: [PATCH 5/7] PPS: serial clients support., Rodolfo Giometti, (Wed Apr 30, 7:41 am)
Re: [PATCH 5/7] PPS: serial clients support., Alan Cox, (Wed Apr 30, 12:28 pm)
Re: [PATCH 5/7] PPS: serial clients support., Rodolfo Giometti, (Fri May 2, 3:33 am)
Re: [PATCH 5/7] PPS: serial clients support., Alan Cox, (Fri May 2, 6:18 am)
Re: [PATCH 5/7] PPS: serial clients support., Rodolfo Giometti, (Fri May 2, 6:45 am)
Re: [PATCH 5/7] PPS: serial clients support., Alan Cox, (Fri May 2, 8:56 am)
Re: [PATCH 5/7] PPS: serial clients support., Rodolfo Giometti, (Fri May 2, 5:09 pm)
Re: [PATCH 5/7] PPS: serial clients support., Rodolfo Giometti, (Fri Apr 11, 4:49 am)
Re: [PATCH 5/7] PPS: serial clients support., Serge Belyshev, (Fri Apr 11, 10:43 am)
Re: [PATCH 5/7] PPS: serial clients support., Rodolfo Giometti, (Fri Apr 11, 12:58 pm)
[PATCH 7/7] PPS: parallel port clients support., Rodolfo Giometti, (Thu Apr 10, 2:22 pm)
speck-geostationary