Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build fix for modular builds

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Andrew Morton
Date: Wednesday, April 30, 2008 - 8:34 am

On Wed, 30 Apr 2008 10:39:31 -0400 "Michael Krufky" <mkrufky@linuxtv.org> wrote:


I worry about this case:

		case 0x42:
		case 0x43:
		case 0x4a:
		case 0x4b:
			/* If chip is not tda8290, don't register.
			   since it can be tda9887*/
			if (tuner_symbol_probe(tda829x_probe, t->i2c->adapter,
					       t->i2c->addr) == 0) {
				tuner_dbg("tda829x detected\n");
			} else {
				/* Default is being tda9887 */
				t->type = TUNER_TDA9887;
				t->mode_mask = T_RADIO | T_ANALOG_TV |
					       T_DIGITAL_TV;
				t->mode = T_STANDBY;
				goto register_client;
			}
			break;

did we really want to go ahead and perform registration if
tuner_symbol_probe() failed?


--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PATCHES] V4L/DVB updates and fixes for 2.6.26, Mauro Carvalho Chehab, (Tue Apr 29, 2:50 pm)
Re: [GIT PATCHES] V4L/DVB updates and fixes for 2.6.26, Linus Torvalds, (Tue Apr 29, 2:59 pm)
Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and ..., Mauro Carvalho Chehab, (Tue Apr 29, 5:00 pm)
Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and ..., Patrick Boettcher, (Wed Apr 30, 1:02 am)
Re: [patch, -git] drivers/media build fix for modular builds, Mauro Carvalho Chehab, (Wed Apr 30, 8:25 am)
Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build ..., Andrew Morton, (Wed Apr 30, 8:34 am)
Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build ..., Mauro Carvalho Chehab, (Wed Apr 30, 8:48 am)
Re: [patch, -git] drivers/media build fix for modular builds, Mauro Carvalho Chehab, (Wed Apr 30, 9:12 am)
Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and ..., Mauro Carvalho Chehab, (Wed Apr 30, 12:03 pm)
Re: [patch, -git] drivers/media build fix for modular builds, Mauro Carvalho Chehab, (Wed Apr 30, 2:35 pm)