Re: [patch, -git] drivers/media build fix for modular builds

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: David Miller <davem@...>
Cc: <mchehab@...>, <torvalds@...>, <akpm@...>, <linux-dvb-maintainer@...>, <video4linux-list@...>, <linux-kernel@...>, <sfr@...>, Sam Ravnborg <sam@...>
Date: Wednesday, April 30, 2008 - 4:13 am

* David Miller <davem@davemloft.net> wrote:


i think any build which has the media drivers only as modules will 
trigger it, so it's rather widespread. My fix has held up fine for 10 
randconfigs so far so it should do the trick.

i'm wondering though why similar problems are not more common. A quick 
look at drivers/Makefile suggests that there are many obj-y rules there 
for driver sub-trees that can be all-modular, not just video:

 obj-y                           += video/
 obj-y                           += char/
 obj-y                           += serial/
 obj-y                           += base/ block/ misc/ mfd/ net/ media/
 obj-y                           += macintosh/
 obj-y                           += ieee1394/
 obj-y                           += cdrom/
 obj-y                           += auxdisplay/
 obj-y                           += i2c/
 obj-y                           += lguest/
 obj-y                           += firmware/

drivers/net/ obj-y is kept alive by the "obj-y wireless/" rule i think, 
but what makes other sub-trees link, like drivers/macintosh/ ?

so kbuild apparently has smarts to handle this case - but somehow it 
still failed for drivers/media/.

Sam Cc:-ed - am i missing some detail in this analysis?

hm, one weird rule is drivers/video/matrox/Makefile's my-obj- rule.

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PATCHES] V4L/DVB updates and fixes for 2.6.26, Mauro Carvalho Chehab, (Tue Apr 29, 5:50 pm)
Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and f..., Patrick Boettcher, (Wed Apr 30, 4:02 am)
Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and f..., Mauro Carvalho Chehab, (Wed Apr 30, 3:03 pm)
Re: [patch, -git] drivers/media build fix for modular builds, Ingo Molnar, (Wed Apr 30, 4:13 am)
Re: [patch, -git] drivers/media build fix for modular builds, Mauro Carvalho Chehab, (Wed Apr 30, 11:25 am)
Re: [patch, -git] drivers/media build fix for modular builds, Mike Galbraith, (Wed Apr 30, 11:48 am)
Re: [patch, -git] drivers/media build fix for modular builds, Mauro Carvalho Chehab, (Wed Apr 30, 12:12 pm)
Re: [patch, -git] drivers/media build fix for modular builds, Mike Galbraith, (Wed Apr 30, 12:31 pm)
Re: [patch, -git] drivers/media build fix for modular builds, Mauro Carvalho Chehab, (Wed Apr 30, 5:35 pm)
Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build f..., Mauro Carvalho Chehab, (Wed Apr 30, 11:48 am)
Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and f..., Mauro Carvalho Chehab, (Tue Apr 29, 8:00 pm)
Re: [GIT PATCHES] V4L/DVB updates and fixes for 2.6.26, Linus Torvalds, (Tue Apr 29, 5:59 pm)